Skip to content

Commit 8d1b1aa

Browse files
author
Takashi Matsuo
authored
[monitoring] fix: mitigate flake (#4153)
fixes #4150
1 parent d88e2c5 commit 8d1b1aa

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
1+
backoff===1.10.0
12
pytest==5.3.2

monitoring/api/v3/uptime-check-client/snippets_test.py

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
import random
1818
import string
1919

20+
import backoff
21+
from google.api_core.exceptions import DeadlineExceeded
2022
import pytest
2123

2224
import snippets
@@ -63,8 +65,17 @@ def test_update_uptime_config(capsys):
6365
new_display_name = random_name(10)
6466
new_uptime_check_path = '/' + random_name(10)
6567
with UptimeFixture() as fixture:
66-
snippets.update_uptime_check_config(
67-
fixture.config.name, new_display_name, new_uptime_check_path)
68+
69+
# We sometimes see the permission error saying the resource
70+
# may not exist. Weirdly DeadlineExceeded instnace is raised
71+
# in this case.
72+
@backoff.on_exception(backoff.expo, DeadlineExceeded, max_time=120)
73+
def call_sample():
74+
snippets.update_uptime_check_config(
75+
fixture.config.name, new_display_name, new_uptime_check_path)
76+
77+
call_sample()
78+
6879
out, _ = capsys.readouterr()
6980
snippets.get_uptime_check_config(fixture.config.name)
7081
out, _ = capsys.readouterr()

0 commit comments

Comments
 (0)