Skip to content

Commit e2053c5

Browse files
authored
fix: make datacatalog == datacatalog_v1 (#206)
Fixes #116 I have verified that v1beta1 -> v1 is additive, so this is *not* a breaking change. See internal changelist 390485345 for the proto level diff and successful run through the proto brekaing change detector
1 parent d597899 commit e2053c5

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

datacatalog/v1beta1/conftest.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,19 @@ def entry(client, entry_group_name):
8585
random_entry_id = "example_entry_{}_{}".format(
8686
now.strftime("%Y%m%d%H%M%S"), uuid.uuid4().hex[:8]
8787
)
88-
entry = datacatalog_v1beta1.CreateEntryRequest
89-
entry = client.create_entry(
90-
request={"parent": entry_group_name, "entry_id": random_entry_id, "entry": {"type_": "DATA_STREAM", "name": "samples_test_entry"}}
88+
89+
request = datacatalog_v1beta1.CreateEntryRequest(
90+
parent=entry_group_name,
91+
entry_id=random_entry_id,
92+
entry=datacatalog_v1beta1.Entry(
93+
type_=datacatalog_v1beta1.EntryType.DATA_STREAM,
94+
name="samples_test_entry",
95+
user_specified_system="sample_system",
96+
)
9197
)
98+
99+
entry = client.create_entry(request)
100+
92101
yield entry.name
93102
client.delete_entry(request={"name": entry.name})
94103

0 commit comments

Comments
 (0)