Skip to content

migrated README files still point to the old repository #10628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dandhlee opened this issue Sep 15, 2023 · 4 comments · Fixed by #11451
Closed

migrated README files still point to the old repository #10628

dandhlee opened this issue Sep 15, 2023 · 4 comments · Fixed by #11451
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: docs Improvement to the documentation for an API.

Comments

@dandhlee
Copy link
Collaborator

Looks like we need to perform a readme review on some of the migrated samples, Yu-Han helped mention that there might be a few more that still point to the googleapis/python-* repos. #10200 (comment)

@dandhlee dandhlee added type: docs Improvement to the documentation for an API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 15, 2023
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 15, 2023
@dandhlee
Copy link
Collaborator Author

I'll clear the assignee for now in case anyone wants to help update this :)

@dandhlee dandhlee removed the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Sep 15, 2023
@carlosm00
Copy link

Hi team,
I'd love to collaborate, but I am not sure if I am right, so please, correct me if I am wrong.
By reading #10200 (review), I understand that https://github.com/googleapis/python-* entries should be changed to https://github.com/GoogleCloudPlatform/python-docs-samples. I might use the list of merged migrations from pull requests that are closed, merged and are named after 'migrate code from googleapis'.
If this is all correct, I will more than gladly do this task :D
Regards.

@carlosm00
Copy link

Hi @dandhlee,
Would you mind checking my last comment?
Best regards.

@iennae
Copy link
Contributor

iennae commented Mar 27, 2024

@carlosm00 yes, you've caught the gist. things that are in READMEs that point to the old location within the gooleapis org should point to GoogleCloudPlatform. In some cases, samples may have been refactored or updated but the READMEs are still stale. Thanks for any help you want to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants