Skip to content

ndb Key Snippet is Incorrect #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
howinator opened this issue Oct 4, 2017 · 2 comments
Closed

ndb Key Snippet is Incorrect #1149

howinator opened this issue Oct 4, 2017 · 2 comments

Comments

@howinator
Copy link
Contributor

In which file did you encounter the issue?

appengine/standard/ndb/entities/snippets.py

Did you change the file? If so, how?

I have a fix which properly describes that keys are an instance property and not a class property. You can see this change here.

Describe the issue

I may have already properly described the issue, but the snipped in one of the ndb snippets indicates that the key property is a class attribute. It is actually an instance attribute. My branch above fixes this and I can submit a PR once I get the 👍 on this issue.

@theacodes
Copy link
Contributor

Thanks, @howinator, would you be interested in sending a pull request to fix this?

@howinator
Copy link
Contributor Author

howinator commented Oct 4, 2017

Of course, @jonparrott. PR opened as #1150 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants