Skip to content

Commit 2e3badb

Browse files
authored
Add some instructions to the MSRV (#3604)
There is no easy way to determine the MSRV for TaskChampion, other than somehow pulling the right version of the source and grepping for it. In practice, if we update the `taskchampion` dependency to one that has a higher MSRV, we'll get a build error and find this comment. And if we get an error building Taskwarrior due to an old MSRV (for example if something changes on `crates.io`) then we will also find this comment. This also removes some superfluous dependency versions from the root workspace. `src/taskchampion-cpp/Cargo.toml` specifies versions directly.
1 parent 6cfbb16 commit 2e3badb

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

.github/workflows/checks.yml

+3
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ jobs:
2929

3030
- uses: actions-rs/toolchain@v1
3131
with:
32+
# If this version is old enough to cause errors, or older than the
33+
# TaskChampion MSRV, bump it to the MSRV of the currently-required
34+
# TaskChampion package; if necessary, bump that version as well.
3235
toolchain: "1.73.0" # MSRV
3336
override: true
3437

Cargo.toml

-10
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,3 @@ members = [
55
]
66

77
resolver = "2"
8-
9-
# All Rust dependencies are defined here, and then referenced by the
10-
# Cargo.toml's in the members with `foo.workspace = true`.
11-
[workspace.dependencies]
12-
anyhow = "1.0"
13-
ffizz-header = "0.5"
14-
libc = "0.2.136"
15-
pretty_assertions = "1"
16-
regex = "^1.10.2"
17-
taskchampion = "0.6"

0 commit comments

Comments
 (0)