fix password reset email

Author: visualjerk

server/services/auth-management/notifier.js

@@ -44,7 +44,23 @@ module.exports = function (app) {
       user.language || 'en'
     );
 
-    const token = user.verifyToken || user.resetToken || user.changeToken;
+    let token;
+
+    switch (linktype) {
+    case 'invite-email':
+      token = user.verifyToken;
+      break;
+    case 'verify':
+      token = user.verifyToken;
+      break;
+    case 'reset':
+      token = user.resetToken;
+      break;
+    case 'verifyChanges':
+      token = user.changeToken;
+      break;
+    }
+
     const hashLink = getLink(linktype, token || null);
     const frontURL = app.get('frontURL');
     const backURL = app.get('baseURL');
@@ -96,9 +112,7 @@ module.exports = function (app) {
     if (app.get('debug')) {
       const filename = String(Date.now()) + '.html';
       const filepath = path.join(__dirname, '../../../tmp/emails/', filename);
-      fs.outputFile(filepath, email.html).catch(err => {
-        app.error('Error saving email', err);
-      });
+      fs.outputFileSync(filepath, email.html);
     }
 
     return app
@@ -125,7 +139,11 @@ module.exports = function (app) {
           user
         );
       case 'resendVerifySignup':
-        return buildEmail('verify-email', 'Confirm signup', 'verify', user);
+        return buildEmail(
+          'verify-email',
+          'Confirm signup',
+          'verify',
+          user);
       case 'verifySignup':
         return buildEmail(
           'email-verified',

test/services/auth-management.test.js

@@ -1,10 +1,73 @@
 const assert = require('assert');
 const app = require('../../server/app');
+const service = app.service('authManagement');
+const userService = app.service('users');
+const fs = require('fs-extra');
+const path = require('path');
+const cheerio = require('cheerio');
+let user = null;
 
 describe('\'authManagement\' service', () => {
-  it('registered the service', () => {
-    const service = app.service('authManagement');
+  before(function(done) {
+    this.server = app.listen(3031);
+    this.server.once('listening', () => done());
+  });
+
+  after(function(done) {
+    this.server.close(done);
+  });
+
+  beforeEach(async () => {
+    await app.get('mongooseClient').connection.dropDatabase();
+    user = await userService.create({
+      email: '[email protected]',
+      password: '1234',
+      name: 'Peter',
+      role: 'admin'
+    });
+  });
+
+  afterEach(async () => {
+    await app.get('mongooseClient').connection.dropDatabase();
+    user = null;
+  });
 
+  it('registered the service', () => {
     assert.ok(service, 'Registered the service');
   });
+
+  it('can reset password', async () => {
+    await service.create({
+      action: 'sendResetPwd',
+      value: {
+        email: user.email
+      }
+    });
+
+    const token = await getTokenFromMail();
+
+    const result = await service.create({
+      action: 'resetPwdLong',
+      value: {
+        token,
+        password: '123456'
+      }
+    });
+    assert.ok(result, 'password can be reset');
+  });
 });
+
+const getTokenFromMail = async () => {
+  // Get token from tmp email file
+  const mailDir = path.join(__dirname, '../../tmp/emails');
+  const fileName = await fs.readdirSync(mailDir)[0];
+  const mailFile = path.join(mailDir, fileName);
+  const mailContent = await fs.readFileSync(mailFile, 'utf8');
+  const $ = await cheerio.load(mailContent);
+  let url;
+  await $('a.btn-primary').each((i, el) => {
+    url = el.attribs['href'];
+  });
+  const token = url.split('/').pop();
+  return token;
+};