Skip to content

Commit a8c4c93

Browse files
silpidhuasilpidhua
committed
feat: analytics engine v3 feature changes
feat: analytics engine v3 feature changes
1 parent bc6dd88 commit a8c4c93

File tree

3 files changed

+50
-26
lines changed

3 files changed

+50
-26
lines changed

‎ibm-analytics-engine-api/v2.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import { getSdkHeaders } from '../lib/common';
2727

2828
class IbmAnalyticsEngineApiV2 extends BaseService {
2929

30-
static DEFAULT_SERVICE_URL: string = 'https://ibm-analytics-engine-api.cloud.ibm.com/';
30+
static DEFAULT_SERVICE_URL: string = 'https://api.us-south.ae.cloud.ibm.com';
3131
static DEFAULT_SERVICE_NAME: string = 'ibm_analytics_engine_api';
3232

3333
/*************************

‎test/integration/ibm-analytics-engine-api.v2.test.js

+11-15
Original file line numberDiff line numberDiff line change
@@ -4,23 +4,23 @@ const IbmAnalyticsEngineApiV2 = require('../../dist/ibm-analytics-engine-api/v2'
44
const { IamAuthenticator } = require('../../dist/auth');
55
const authHelper = require('../resources/auth-helper.js');
66
const describe = authHelper.describe; // this runs describe.skip if there is no auth.js file :)
7-
const timeout= 20000; // jest timeout in ms
7+
const timeout = 20000; // jest timeout in ms
88

99
describe('IBM Analytics Engine ApiV2 integration', () => {
1010
const options = authHelper.auth.ibm_analytics_engine_api_v2;
11-
options.authenticator = new IamAuthenticator({apikey: options.apikey});
11+
options.authenticator = new IamAuthenticator({ apikey: options.apikey });
1212
const instanceGuid = options.instanceGuid;
1313

1414
const IbmAnalyticsEngineServiceClient = new IbmAnalyticsEngineApiV2(options);
15-
jest. setTimeout(timeout);
15+
jest.setTimeout(timeout);
1616

1717
// nested describe statements are helpful when organizing multiple categories of an api
1818
describe('analyticsEngines', () => {
19-
let resourceId;
19+
// let resourceId;
2020

2121
it('getAnalyticsEngineById', async done => {
2222
const params = {
23-
instanceGuid: instanceGuid
23+
instanceGuid: instanceGuid,
2424
};
2525

2626
let response;
@@ -29,14 +29,13 @@ describe('IBM Analytics Engine ApiV2 integration', () => {
2929
} catch (err) {
3030
done(err);
3131
}
32-
3332
expect(response.status).toEqual(200);
3433
done();
3534
});
3635

3736
it('getAnalyticsEngineStateById', async done => {
3837
const params = {
39-
instanceGuid: instanceGuid
38+
instanceGuid: instanceGuid,
4039
};
4140

4241
let response;
@@ -45,13 +44,11 @@ describe('IBM Analytics Engine ApiV2 integration', () => {
4544
} catch (err) {
4645
done(err);
4746
}
48-
4947
expect(response.status).toEqual(200);
5048
done();
5149
});
5250

5351
it('createCustomizationRequest', async done => {
54-
5552
// AnalyticsEngineCustomActionScript
5653
const analyticsEngineCustomActionScriptModel = {
5754
source_type: 'http',
@@ -88,7 +85,7 @@ describe('IBM Analytics Engine ApiV2 integration', () => {
8885

8986
it('getAllCustomizationRequests', async done => {
9087
const params = {
91-
instanceGuid: instanceGuid
88+
instanceGuid: instanceGuid,
9289
};
9390

9491
let response;
@@ -103,7 +100,7 @@ describe('IBM Analytics Engine ApiV2 integration', () => {
103100
});
104101

105102
it('getCustomizationRequestById', async done => {
106-
var params = {
103+
const params = {
107104
instanceGuid: instanceGuid,
108105
};
109106

@@ -145,7 +142,7 @@ describe('IBM Analytics Engine ApiV2 integration', () => {
145142

146143
it('resetClusterPassword', async done => {
147144
const params = {
148-
instanceGuid: instanceGuid
145+
instanceGuid: instanceGuid,
149146
};
150147

151148
let response;
@@ -196,7 +193,7 @@ describe('IBM Analytics Engine ApiV2 integration', () => {
196193

197194
it('getLoggingConfig', async done => {
198195
const params = {
199-
instanceGuid: instanceGuid
196+
instanceGuid: instanceGuid,
200197
};
201198

202199
let response;
@@ -212,7 +209,7 @@ describe('IBM Analytics Engine ApiV2 integration', () => {
212209

213210
it('deleteLoggingConfig', async done => {
214211
const params = {
215-
instanceGuid: instanceGuid
212+
instanceGuid: instanceGuid,
216213
};
217214

218215
let response;
@@ -226,7 +223,6 @@ describe('IBM Analytics Engine ApiV2 integration', () => {
226223
done();
227224
});
228225

229-
230226
it('updatePrivateEndpointWhitelist', async done => {
231227
const ipRanges = ['testString'];
232228
const action = 'add';

‎test/unit/ibm-analytics-engine-api.v2.test.js

+38-10
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,9 @@ describe('IbmAnalyticsEngineApiV2', () => {
5656

5757
expect(getAuthenticatorMock).toHaveBeenCalled();
5858
expect(testInstance.baseOptions.authenticator).toBeInstanceOf(NoAuthAuthenticator);
59-
expect(testInstance.baseOptions.serviceName).toBe(IbmAnalyticsEngineApiV2.DEFAULT_SERVICE_NAME);
59+
expect(testInstance.baseOptions.serviceName).toBe(
60+
IbmAnalyticsEngineApiV2.DEFAULT_SERVICE_NAME
61+
);
6062
expect(testInstance.baseOptions.serviceUrl).toBe(IbmAnalyticsEngineApiV2.DEFAULT_SERVICE_URL);
6163
expect(testInstance).toBeInstanceOf(IbmAnalyticsEngineApiV2);
6264
});
@@ -220,7 +222,9 @@ describe('IbmAnalyticsEngineApiV2', () => {
220222
instanceGuid: instanceGuid,
221223
};
222224

223-
const getAnalyticsEngineStateByIdResult = ibmAnalyticsEngineApi.getAnalyticsEngineStateById(params);
225+
const getAnalyticsEngineStateByIdResult = ibmAnalyticsEngineApi.getAnalyticsEngineStateById(
226+
params
227+
);
224228

225229
// all methods should return a Promise
226230
expectToBePromise(getAnalyticsEngineStateByIdResult);
@@ -309,7 +313,9 @@ describe('IbmAnalyticsEngineApiV2', () => {
309313
customActions: customActions,
310314
};
311315

312-
const createCustomizationRequestResult = ibmAnalyticsEngineApi.createCustomizationRequest(params);
316+
const createCustomizationRequestResult = ibmAnalyticsEngineApi.createCustomizationRequest(
317+
params
318+
);
313319

314320
// all methods should return a Promise
315321
expectToBePromise(createCustomizationRequestResult);
@@ -319,7 +325,11 @@ describe('IbmAnalyticsEngineApiV2', () => {
319325

320326
const options = getOptions(createRequestMock);
321327

322-
checkUrlAndMethod(options, '/v2/analytics_engines/{instance_guid}/customization_requests', 'POST');
328+
checkUrlAndMethod(
329+
options,
330+
'/v2/analytics_engines/{instance_guid}/customization_requests',
331+
'POST'
332+
);
323333
const expectedAccept = 'application/json';
324334
const expectedContentType = 'application/json';
325335
checkMediaHeaders(createRequestMock, expectedAccept, expectedContentType);
@@ -383,7 +393,9 @@ describe('IbmAnalyticsEngineApiV2', () => {
383393
instanceGuid: instanceGuid,
384394
};
385395

386-
const getAllCustomizationRequestsResult = ibmAnalyticsEngineApi.getAllCustomizationRequests(params);
396+
const getAllCustomizationRequestsResult = ibmAnalyticsEngineApi.getAllCustomizationRequests(
397+
params
398+
);
387399

388400
// all methods should return a Promise
389401
expectToBePromise(getAllCustomizationRequestsResult);
@@ -393,7 +405,11 @@ describe('IbmAnalyticsEngineApiV2', () => {
393405

394406
const options = getOptions(createRequestMock);
395407

396-
checkUrlAndMethod(options, '/v2/analytics_engines/{instance_guid}/customization_requests', 'GET');
408+
checkUrlAndMethod(
409+
options,
410+
'/v2/analytics_engines/{instance_guid}/customization_requests',
411+
'GET'
412+
);
397413
const expectedAccept = 'application/json';
398414
const expectedContentType = undefined;
399415
checkMediaHeaders(createRequestMock, expectedAccept, expectedContentType);
@@ -453,7 +469,9 @@ describe('IbmAnalyticsEngineApiV2', () => {
453469
requestId: requestId,
454470
};
455471

456-
const getCustomizationRequestByIdResult = ibmAnalyticsEngineApi.getCustomizationRequestById(params);
472+
const getCustomizationRequestByIdResult = ibmAnalyticsEngineApi.getCustomizationRequestById(
473+
params
474+
);
457475

458476
// all methods should return a Promise
459477
expectToBePromise(getCustomizationRequestByIdResult);
@@ -463,7 +481,11 @@ describe('IbmAnalyticsEngineApiV2', () => {
463481

464482
const options = getOptions(createRequestMock);
465483

466-
checkUrlAndMethod(options, '/v2/analytics_engines/{instance_guid}/customization_requests/{request_id}', 'GET');
484+
checkUrlAndMethod(
485+
options,
486+
'/v2/analytics_engines/{instance_guid}/customization_requests/{request_id}',
487+
'GET'
488+
);
467489
const expectedAccept = 'application/json';
468490
const expectedContentType = undefined;
469491
checkMediaHeaders(createRequestMock, expectedAccept, expectedContentType);
@@ -898,7 +920,9 @@ describe('IbmAnalyticsEngineApiV2', () => {
898920
action: action,
899921
};
900922

901-
const updatePrivateEndpointWhitelistResult = ibmAnalyticsEngineApi.updatePrivateEndpointWhitelist(params);
923+
const updatePrivateEndpointWhitelistResult = ibmAnalyticsEngineApi.updatePrivateEndpointWhitelist(
924+
params
925+
);
902926

903927
// all methods should return a Promise
904928
expectToBePromise(updatePrivateEndpointWhitelistResult);
@@ -908,7 +932,11 @@ describe('IbmAnalyticsEngineApiV2', () => {
908932

909933
const options = getOptions(createRequestMock);
910934

911-
checkUrlAndMethod(options, '/v2/analytics_engines/{instance_guid}/private_endpoint_whitelist', 'PATCH');
935+
checkUrlAndMethod(
936+
options,
937+
'/v2/analytics_engines/{instance_guid}/private_endpoint_whitelist',
938+
'PATCH'
939+
);
912940
const expectedAccept = 'application/json';
913941
const expectedContentType = 'application/json';
914942
checkMediaHeaders(createRequestMock, expectedAccept, expectedContentType);

0 commit comments

Comments
 (0)