Skip to content

Commit c280f29

Browse files
Akhil-JAkhil-J
committed
fix: fix lint issues
Signed-off-by: Akhil Jonnalagadda <[email protected]>
1 parent dadb28c commit c280f29

File tree

4 files changed

+271
-98
lines changed

4 files changed

+271
-98
lines changed

‎examples/ibm-analytics-engine-api.v3.test.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -395,7 +395,10 @@ describe('IbmAnalyticsEngineApiV3', () => {
395395

396396
const allResults = [];
397397
try {
398-
const pager = new IbmAnalyticsEngineApiV3.ApplicationsPager(ibmAnalyticsEngineApiService, params);
398+
const pager = new IbmAnalyticsEngineApiV3.ApplicationsPager(
399+
ibmAnalyticsEngineApiService,
400+
params
401+
);
399402
while (pager.hasNext()) {
400403
const nextPage = await pager.getNext();
401404
expect(nextPage).not.toBeNull();

‎ibm-analytics-engine-api/v3.ts

+57-30
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,10 @@ import {
2929
getAuthenticatorFromEnvironment,
3030
validateParams,
3131
UserOptions,
32+
getNewLogger,
33+
SDKLogger,
3234
} from 'ibm-cloud-sdk-core';
3335
import { getSdkHeaders } from '../lib/common';
34-
import { getNewLogger, SDKLogger } from 'ibm-cloud-sdk-core';
3536

3637
/**
3738
* Manage serverless Spark instances and run applications.
@@ -58,7 +59,7 @@ class IbmAnalyticsEngineApiV3 extends BaseService {
5859
* if no mapping for the region exists
5960
*/
6061
public static getServiceUrlForRegion(region: string): string {
61-
return this._regionalEndpoints.get(region)
62+
return this._regionalEndpoints.get(region);
6263
}
6364

6465
/*************************
@@ -247,7 +248,17 @@ class IbmAnalyticsEngineApiV3 extends BaseService {
247248
): Promise<IbmAnalyticsEngineApiV3.Response<IbmAnalyticsEngineApiV3.InstanceHomeResponse>> {
248249
const _params = { ...params };
249250
const _requiredParams = ['instanceId'];
250-
const _validParams = ['instanceId', 'newInstanceId', 'newProvider', 'newType', 'newRegion', 'newEndpoint', 'newHmacAccessKey', 'newHmacSecretKey', 'headers'];
251+
const _validParams = [
252+
'instanceId',
253+
'newInstanceId',
254+
'newProvider',
255+
'newType',
256+
'newRegion',
257+
'newEndpoint',
258+
'newHmacAccessKey',
259+
'newHmacSecretKey',
260+
'headers',
261+
];
251262
const _validationErrors = validateParams(_params, _requiredParams, _validParams);
252263
if (_validationErrors) {
253264
return Promise.reject(_validationErrors);
@@ -437,7 +448,7 @@ class IbmAnalyticsEngineApiV3 extends BaseService {
437448
return Promise.reject(_validationErrors);
438449
}
439450

440-
const body = _params.body;
451+
const { body } = _params;
441452
const path = {
442453
'instance_id': _params.instanceId,
443454
};
@@ -494,7 +505,7 @@ class IbmAnalyticsEngineApiV3 extends BaseService {
494505
return Promise.reject(_validationErrors);
495506
}
496507

497-
const body = _params.body;
508+
const { body } = _params;
498509
const path = {
499510
'instance_id': _params.instanceId,
500511
};
@@ -734,7 +745,16 @@ class IbmAnalyticsEngineApiV3 extends BaseService {
734745
): Promise<IbmAnalyticsEngineApiV3.Response<IbmAnalyticsEngineApiV3.ApplicationCollection>> {
735746
const _params = { ...params };
736747
const _requiredParams = ['instanceId'];
737-
const _validParams = ['instanceId', 'state', 'startTimeInterval', 'submissionTimeInterval', 'endTimeInterval', 'limit', 'start', 'headers'];
748+
const _validParams = [
749+
'instanceId',
750+
'state',
751+
'startTimeInterval',
752+
'submissionTimeInterval',
753+
'endTimeInterval',
754+
'limit',
755+
'start',
756+
'headers',
757+
];
738758
const _validationErrors = validateParams(_params, _requiredParams, _validParams);
739759
if (_validationErrors) {
740760
return Promise.reject(_validationErrors);
@@ -876,13 +896,7 @@ class IbmAnalyticsEngineApiV3 extends BaseService {
876896
path,
877897
},
878898
defaultOptions: extend(true, {}, this.baseOptions, {
879-
headers: extend(
880-
true,
881-
sdkHeaders,
882-
{
883-
},
884-
_params.headers
885-
),
899+
headers: extend(true, sdkHeaders, {}, _params.headers),
886900
}),
887901
};
888902

@@ -902,7 +916,9 @@ class IbmAnalyticsEngineApiV3 extends BaseService {
902916
*/
903917
public getApplicationState(
904918
params: IbmAnalyticsEngineApiV3.GetApplicationStateParams
905-
): Promise<IbmAnalyticsEngineApiV3.Response<IbmAnalyticsEngineApiV3.ApplicationGetStateResponse>> {
919+
): Promise<
920+
IbmAnalyticsEngineApiV3.Response<IbmAnalyticsEngineApiV3.ApplicationGetStateResponse>
921+
> {
906922
const _params = { ...params };
907923
const _requiredParams = ['instanceId', 'applicationId'];
908924
const _validParams = ['instanceId', 'applicationId', 'headers'];
@@ -959,7 +975,9 @@ class IbmAnalyticsEngineApiV3 extends BaseService {
959975
*/
960976
public getCurrentResourceConsumption(
961977
params: IbmAnalyticsEngineApiV3.GetCurrentResourceConsumptionParams
962-
): Promise<IbmAnalyticsEngineApiV3.Response<IbmAnalyticsEngineApiV3.CurrentResourceConsumptionResponse>> {
978+
): Promise<
979+
IbmAnalyticsEngineApiV3.Response<IbmAnalyticsEngineApiV3.CurrentResourceConsumptionResponse>
980+
> {
963981
const _params = { ...params };
964982
const _requiredParams = ['instanceId'];
965983
const _validParams = ['instanceId', 'headers'];
@@ -1012,7 +1030,9 @@ class IbmAnalyticsEngineApiV3 extends BaseService {
10121030
*/
10131031
public getResourceConsumptionLimits(
10141032
params: IbmAnalyticsEngineApiV3.GetResourceConsumptionLimitsParams
1015-
): Promise<IbmAnalyticsEngineApiV3.Response<IbmAnalyticsEngineApiV3.ResourceConsumptionLimitsResponse>> {
1033+
): Promise<
1034+
IbmAnalyticsEngineApiV3.Response<IbmAnalyticsEngineApiV3.ResourceConsumptionLimitsResponse>
1035+
> {
10161036
const _params = { ...params };
10171037
const _requiredParams = ['instanceId'];
10181038
const _validParams = ['instanceId', 'headers'];
@@ -1070,7 +1090,9 @@ class IbmAnalyticsEngineApiV3 extends BaseService {
10701090
*/
10711091
public replaceLogForwardingConfig(
10721092
params: IbmAnalyticsEngineApiV3.ReplaceLogForwardingConfigParams
1073-
): Promise<IbmAnalyticsEngineApiV3.Response<IbmAnalyticsEngineApiV3.LogForwardingConfigResponse>> {
1093+
): Promise<
1094+
IbmAnalyticsEngineApiV3.Response<IbmAnalyticsEngineApiV3.LogForwardingConfigResponse>
1095+
> {
10741096
const _params = { ...params };
10751097
const _requiredParams = ['instanceId'];
10761098
const _validParams = ['instanceId', 'enabled', 'sources', 'tags', 'headers'];
@@ -1130,7 +1152,9 @@ class IbmAnalyticsEngineApiV3 extends BaseService {
11301152
*/
11311153
public getLogForwardingConfig(
11321154
params: IbmAnalyticsEngineApiV3.GetLogForwardingConfigParams
1133-
): Promise<IbmAnalyticsEngineApiV3.Response<IbmAnalyticsEngineApiV3.LogForwardingConfigResponse>> {
1155+
): Promise<
1156+
IbmAnalyticsEngineApiV3.Response<IbmAnalyticsEngineApiV3.LogForwardingConfigResponse>
1157+
> {
11341158
const _params = { ...params };
11351159
const _requiredParams = ['instanceId'];
11361160
const _validParams = ['instanceId', 'headers'];
@@ -1185,8 +1209,12 @@ class IbmAnalyticsEngineApiV3 extends BaseService {
11851209
*/
11861210
public configurePlatformLogging(
11871211
params: IbmAnalyticsEngineApiV3.ConfigurePlatformLoggingParams
1188-
): Promise<IbmAnalyticsEngineApiV3.Response<IbmAnalyticsEngineApiV3.LoggingConfigurationResponse>> {
1189-
IbmAnalyticsEngineApiV3._logger.warn('A deprecated operation has been invoked: configurePlatformLogging');
1212+
): Promise<
1213+
IbmAnalyticsEngineApiV3.Response<IbmAnalyticsEngineApiV3.LoggingConfigurationResponse>
1214+
> {
1215+
IbmAnalyticsEngineApiV3._logger.warn(
1216+
'A deprecated operation has been invoked: configurePlatformLogging'
1217+
);
11901218
const _params = { ...params };
11911219
const _requiredParams = ['instanceGuid'];
11921220
const _validParams = ['instanceGuid', 'enable', 'headers'];
@@ -1246,8 +1274,12 @@ class IbmAnalyticsEngineApiV3 extends BaseService {
12461274
*/
12471275
public getLoggingConfiguration(
12481276
params: IbmAnalyticsEngineApiV3.GetLoggingConfigurationParams
1249-
): Promise<IbmAnalyticsEngineApiV3.Response<IbmAnalyticsEngineApiV3.LoggingConfigurationResponse>> {
1250-
IbmAnalyticsEngineApiV3._logger.warn('A deprecated operation has been invoked: getLoggingConfiguration');
1277+
): Promise<
1278+
IbmAnalyticsEngineApiV3.Response<IbmAnalyticsEngineApiV3.LoggingConfigurationResponse>
1279+
> {
1280+
IbmAnalyticsEngineApiV3._logger.warn(
1281+
'A deprecated operation has been invoked: getLoggingConfiguration'
1282+
);
12511283
const _params = { ...params };
12521284
const _requiredParams = ['instanceGuid'];
12531285
const _validParams = ['instanceGuid', 'headers'];
@@ -1432,13 +1464,7 @@ class IbmAnalyticsEngineApiV3 extends BaseService {
14321464
path,
14331465
},
14341466
defaultOptions: extend(true, {}, this.baseOptions, {
1435-
headers: extend(
1436-
true,
1437-
sdkHeaders,
1438-
{
1439-
},
1440-
_params.headers
1441-
),
1467+
headers: extend(true, sdkHeaders, {}, _params.headers),
14421468
}),
14431469
};
14441470

@@ -2061,6 +2087,7 @@ namespace IbmAnalyticsEngineApiV3 {
20612087
*/
20622088
export class ApplicationsPager {
20632089
protected _hasNext: boolean;
2090+
20642091
protected pageContext: any;
20652092

20662093
protected client: IbmAnalyticsEngineApiV3;
@@ -2114,7 +2141,7 @@ namespace IbmAnalyticsEngineApiV3 {
21142141

21152142
let next = null;
21162143
if (result && result.next) {
2117-
next = result.next.start
2144+
next = result.next.start;
21182145
}
21192146
this.pageContext.next = next;
21202147
if (!this.pageContext.next) {

‎test/integration/ibm-analytics-engine-api.v3.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ describe('IbmAnalyticsEngineApiV3_integration', () => {
7171

7272
const config = readExternalSources(IbmAnalyticsEngineApiV3.DEFAULT_SERVICE_NAME);
7373
expect(config).not.toBeNull();
74-
74+
7575
ibmAnalyticsEngineApiService.enableRetries();
7676
});
7777

0 commit comments

Comments
 (0)