Skip to content

fix: HTTP transport should take a URL #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2020
Merged

fix: HTTP transport should take a URL #252

merged 2 commits into from
Apr 22, 2020

Conversation

abmusse
Copy link
Member

@abmusse abmusse commented Apr 21, 2020

Fixes #247

@abmusse abmusse requested a review from kadler April 21, 2020 20:42
kadler
kadler approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@kadler kadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the password check using the same error message as the url check.

@abmusse abmusse requested a review from kadler April 22, 2020 14:48
@kadler kadler merged commit 34e4e37 into master Apr 22, 2020
@kadler kadler deleted the fix-http-transport-url branch April 22, 2020 17:21
@abmusse abmusse mentioned this pull request Apr 23, 2020
Merged
abmusse
abmusse commented Apr 30, 2020
View reviewed changes
lib/Deprecated.js
}
options.transportOptions = { ...options.transportOptions, ...option };
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this change is the cause of unit test failure. We should still append user passed options to the transportOptions like we did before.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. I should have caught that.

@abmusse abmusse mentioned this pull request Apr 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadler kadler kadler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP Transport should take a URL
2 participants
@abmusse @kadler