Skip to content

Commit 9c0d892

Browse files
authored
[PR Template] Service is monitored and testing URL (#994)
Remind authors to make sure service public URL includes testing Mode and is monitored via Prometheus & Grafana
1 parent 3054352 commit 9c0d892

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
- [ ] Service has placement constraints or is global
1919
- [ ] Service is restartable
2020
- [ ] Service restart is zero-downtime
21+
- [ ] Service is monitored (via prometheus and grafana)
2122
- [ ] Service is not bound to one specific node (e.g. via files or volumes)
2223
- [ ] Relevant OPS E2E Test are added
23-
- [ ] Service's Public URL is included in maintenance mode -->
24+
- [ ] Service's Public URL is included in maintenance mode
25+
- [ ] Service's Public URL is included in testing mode -->

0 commit comments

Comments
 (0)