Make login form password save friendly (#315)

* make login form password save friendly

Author: oetiker

services/web/client/source/class/qxapp/auth/core/BaseAuthPage.js

@@ -23,7 +23,17 @@ qx.Class.define("qxapp.auth.core.BaseAuthPage", {
       width: 300,
       height: 250
     });
-
+    // at least chrome hates it when a password input field exists
+    // outside a form, so lets accomodate him
+    this.addListenerOnce("appear", e => {
+      let el = this.getContentElement();
+      let form = this._form = new qx.html.Element("form", null, {
+        name: "fakeLoginform",
+        autocomplete: "on"
+      });
+      form.insertBefore(el);
+      el.insertInto(form);
+    });
     this._buildPage();
   },
 
@@ -44,7 +54,11 @@ qx.Class.define("qxapp.auth.core.BaseAuthPage", {
   */
 
   members: {
-
+    /**
+     * when all is said and done we should remove the form so that the password manager
+     * knows to save the content of the form. so we save it here.
+     */
+    _form: null,
     /**
      * This method gets called upon construction and
      * must be overriden in a subclass

services/web/client/source/class/qxapp/auth/ui/LoginPage.js

@@ -47,11 +47,13 @@ qx.Class.define("qxapp.auth.ui.LoginPage", {
       email.setPlaceholder(this.tr("Your email address"));
       email.setRequired(true);
       this.add(email);
+      email.getContentElement().setAttribute("autocomplete", "username");
       this.__form.add(email, "", qx.util.Validate.email(), "email", null);
 
       let pass = new qx.ui.form.PasswordField();
       pass.setPlaceholder(this.tr("Your password"));
       pass.setRequired(true);
+      pass.getContentElement().setAttribute("autocomplete", "current-password");
       this.add(pass);
       this.__form.add(pass, "", null, "password", null);
 
@@ -130,6 +132,9 @@ qx.Class.define("qxapp.auth.ui.LoginPage", {
 
       let successFun = function(log) {
         this.fireDataEvent("done", log.message);
+        // we don't need the form any more, so remove it
+        // and thus tell the password manager to save the content
+        this._form.dispose();
       };
 
       let failFun = function(msg) {