Skip to content

Commit 1c57f2a

Browse files
committed
fix issues after renaming
1 parent 5cb4fe3 commit 1c57f2a

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

services/director/src/simcore_service_director/producer.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,7 @@ async def _check_node_uuid_available(
6363
# not filtering by "swarm_stack_name" label because it's safer
6464
list_of_running_services_w_uuid = await client.services.list(
6565
filters={
66-
"label": f"{_to_simcore_runtime_docker_label_key('node_id')}="
67-
+ node_uuid
66+
"label": f"{_to_simcore_runtime_docker_label_key('node_id')}={node_uuid}"
6867
}
6968
)
7069
except aiodocker.exceptions.DockerError as err:
@@ -1036,7 +1035,7 @@ async def get_services_details(
10361035
)
10371036
if study_id:
10381037
filters.append(
1039-
f"{_to_simcore_runtime_docker_label_key('study_id')}=" + study_id
1038+
f"{_to_simcore_runtime_docker_label_key('project_id')}=" + study_id
10401039
)
10411040
list_running_services = await client.services.list(
10421041
filters={"label": filters}

services/director/tests/test_producer.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ async def test_service_assigned_env_variables(
174174
for service in started_services:
175175
service_uuid = service["service_uuid"]
176176
list_of_services = client.services.list(
177-
filters={"label": "uuid=" + service_uuid}
177+
filters={"label": f"io.simcore.runtime.node-id={service_uuid}"}
178178
)
179179
assert len(list_of_services) == 1
180180
docker_service = list_of_services[0]
@@ -219,7 +219,9 @@ async def test_interactive_service_published_port(docker_network, run_services):
219219

220220
client = docker.from_env()
221221
service_uuid = service["service_uuid"]
222-
list_of_services = client.services.list(filters={"label": "uuid=" + service_uuid})
222+
list_of_services = client.services.list(
223+
filters={"label": f"io.simcore.runtime.node-id={service_uuid}"}
224+
)
223225
assert len(list_of_services) == 1
224226

225227
docker_service = list_of_services[0]
@@ -265,7 +267,7 @@ async def test_interactive_service_in_correct_network(
265267
client = docker.from_env()
266268
service_uuid = service["service_uuid"]
267269
list_of_services = client.services.list(
268-
filters={"label": "uuid=" + service_uuid}
270+
filters={"label": f"io.simcore.runtime.node-id={service_uuid}"}
269271
)
270272
assert list_of_services
271273
assert len(list_of_services) == 1
@@ -285,7 +287,7 @@ async def test_dependent_services_have_common_network(docker_network, run_servic
285287
client = docker.from_env()
286288
service_uuid = service["service_uuid"]
287289
list_of_services = client.services.list(
288-
filters={"label": "uuid=" + service_uuid}
290+
filters={"label": f"io.simcore.runtime.node-id={service_uuid}"}
289291
)
290292
# there is one dependency per service
291293
assert len(list_of_services) == 2

0 commit comments

Comments
 (0)