Skip to content

Commit 2572fd4

Browse files
GitHKAndrei Neagu
and
Andrei Neagu
authored
🐛 fix dynamic-sidecar pretences save and shutdown event ordering (#5156)
Co-authored-by: Andrei Neagu <[email protected]>
1 parent df8953b commit 2572fd4

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/long_running_tasks.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -277,16 +277,16 @@ async def _send_resource_tracking_stop(platform_status: SimcorePlatformStatus):
277277
await send_service_stopped(app, simcore_platform_status)
278278

279279
try:
280-
with log_context(_logger, logging.INFO, "save user services preferences"):
281-
if user_services_preferences.is_feature_enabled(app):
282-
await user_services_preferences.save_user_services_preferences(app)
283-
284280
progress.update(message="running docker-compose-down", percent=0.1)
285281

286282
await run_before_shutdown_actions(
287283
shared_store, settings.DY_SIDECAR_CALLBACKS_MAPPING.before_shutdown
288284
)
289285

286+
with log_context(_logger, logging.INFO, "save user services preferences"):
287+
if user_services_preferences.is_feature_enabled(app):
288+
await user_services_preferences.save_user_services_preferences(app)
289+
290290
result = await _retry_docker_compose_down(shared_store.compose_spec, settings)
291291
_raise_for_errors(result, "down")
292292

0 commit comments

Comments
 (0)