Skip to content

Commit 70abf85

Browse files
committed
fixes director
1 parent 04f7d7e commit 70abf85

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

services/catalog/tests/unit/test_services_director.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
import pytest
1313
from fastapi import FastAPI
14+
from models_library.services_metadata_published import ServiceMetaDataPublished
1415
from pytest_simcore.helpers.monkeypatch_envs import setenvs_from_dict
1516
from pytest_simcore.helpers.typing_env import EnvVarsDict
1617
from respx.router import MockRouter
@@ -35,6 +36,7 @@ def app_environment(
3536
async def test_director_client_high_level_api(
3637
background_tasks_setup_disabled: None,
3738
rabbitmq_and_rpc_setup_disabled: None,
39+
expected_director_list_services: list[dict[str, Any]],
3840
mocked_director_service_api: MockRouter,
3941
app: FastAPI,
4042
):
@@ -47,20 +49,13 @@ async def test_director_client_high_level_api(
4749
# PING
4850
assert await director_api.is_responsive()
4951

50-
# LIST
51-
all_services = await director_api.list_all_services()
52-
assert mocked_director_service_api["list_services"].called
53-
54-
services_image_digest = {service.image_digest for service in all_services}
55-
assert None not in services_image_digest
56-
assert len(services_image_digest) == len(all_services)
57-
5852
# GET
59-
expected_service = all_services[0]
53+
expected_service = ServiceMetaDataPublished(**expected_director_list_services[0])
6054
assert (
6155
await director_api.get_service(expected_service.key, expected_service.version)
6256
== expected_service
6357
)
58+
# TODO: error handling!
6459

6560

6661
async def test_director_client_low_level_api(

0 commit comments

Comments
 (0)