Skip to content

Commit 7f94db0

Browse files
committed
Fixes test
1 parent ad19e65 commit 7f94db0

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

services/web/server/tests/unit/isolated/test_catalog_api_models.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ def test_from_catalog_to_webapi_service():
6464
"outFile": {
6565
"displayOrder": 0,
6666
"label": "File",
67+
"unit": "second",
6768
"description": "Chosen File",
6869
"type": "data:*/*",
6970
"fileToKeyMap": None,
@@ -78,13 +79,14 @@ def test_from_catalog_to_webapi_service():
7879
replace_service_input_outputs(webapi_service, **RESPONSE_MODEL_POLICY)
7980

8081
# TODO: dev checks... generalize
81-
assert webapi_service["outputs"]["outFile"]["unit"] is None
82-
assert webapi_service["outputs"]["outFile"]["unitShort"] is None
83-
assert webapi_service["outputs"]["outFile"]["unitLong"] is None
82+
assert webapi_service["outputs"]["outFile"]["unit"] is "second"
83+
assert webapi_service["outputs"]["outFile"]["unitShort"] is "s"
84+
assert webapi_service["outputs"]["outFile"]["unitLong"] is "seconds"
8485

86+
# Trimmed!
8587
assert "defaultValue" not in webapi_service["outputs"]["outFile"]
8688

87-
# the rest must be the same
89+
# All None are trimmed
8890
for field, value in catalog_service["outputs"]["outFile"].items():
89-
if field != "defaultValue":
91+
if field != "defaultValue" and value is not None:
9092
assert webapi_service["outputs"]["outFile"][field] == value

0 commit comments

Comments
 (0)