Skip to content

Commit 94de3d7

Browse files
author
Pedro Crespo
committed
Minor changes in docker after discussion with MaG
1 parent e663a1e commit 94de3d7

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

services/sidecar/Dockerfile

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
FROM python:3.6-alpine as base
22

3-
LABEL maintainer="Manuel Guidon guidon"
3+
LABEL maintainer="mguidon"
44

55
ARG DOCKER_GID_ARG=1001
66

@@ -16,7 +16,7 @@ EXPOSE 8000
1616
VOLUME /home/scu/input
1717
VOLUME /home/scu/output
1818
VOLUME /home/scu/log
19-
#VOLUME /var/run/docker.sock TODO: PC->MaG is this using docker??
19+
#VOLUME /var/run/docker.sock DO NOT EXPOSE .. fails!
2020

2121
# -------------------------- Build stage -------------------
2222
# Keeps same folder structure as in repo so we can reuse relative paths
@@ -80,6 +80,8 @@ RUN $PIP --no-cache-dir install -r requirements/prod.txt ;\
8080
#-------------------
8181
FROM base as production
8282

83+
# TODO: PC->MaG some postgresql missing? install non-dev package!?
84+
8385
COPY --from=build-production --chown=scu:scu $HOME/services/sidecar/boot.sh $HOME
8486
COPY --from=build-production --chown=scu:scu $HOME/.venv $HOME/.venv
8587

0 commit comments

Comments
 (0)