Skip to content

Commit a0a5f18

Browse files
committed
remove use of setup
1 parent 9759786 commit a0a5f18

File tree

7 files changed

+4
-11
lines changed

7 files changed

+4
-11
lines changed

packages/service-library/tests/deferred_tasks/example_app.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ def __init__(
9595
)
9696

9797
async def setup(self) -> None:
98-
await self._redis_client.setup()
9998
await self._manager.setup()
10099

101100

packages/service-library/tests/deferred_tasks/test__base_deferred_handler.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ async def redis_client_sdk(
5757
decode_responses=False,
5858
client_name="pytest",
5959
)
60-
await sdk.setup()
6160
yield sdk
6261
await sdk.shutdown()
6362

@@ -430,7 +429,7 @@ async def test_deferred_manager_code_times_out(
430429
get_mocked_deferred_handler: Callable[
431430
[int, timedelta, Callable[[DeferredContext], Awaitable[Any]]],
432431
tuple[dict[MockKeys, Mock], type[BaseDeferredHandler]],
433-
]
432+
],
434433
):
435434
async def _run_that_times_out(_: DeferredContext) -> None:
436435
await asyncio.sleep(1e6)

services/clusters-keeper/src/simcore_service_clusters_keeper/modules/redis.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,9 @@ async def on_startup() -> None:
1616
app.state.redis_client_sdk = None
1717
settings: RedisSettings = get_application_settings(app).CLUSTERS_KEEPER_REDIS
1818
redis_locks_dsn = settings.build_redis_dsn(RedisDatabase.LOCKS)
19-
app.state.redis_client_sdk = client = RedisClientSDK(
19+
app.state.redis_client_sdk = RedisClientSDK(
2020
redis_locks_dsn, client_name=APP_NAME
2121
)
22-
await client.setup()
2322

2423
async def on_shutdown() -> None:
2524
redis_client_sdk: None | RedisClientSDK = app.state.redis_client_sdk

services/director-v2/tests/unit/test_utils_distributed_identifier.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,6 @@ async def redis_client_sdk(
176176
client = RedisClientSDK(redis_resources_dns, client_name="pytest")
177177
assert client
178178
assert client.redis_dsn == redis_resources_dns
179-
await client.setup()
180179
# cleanup, previous run's leftovers
181180
await client.redis.flushall()
182181

services/efs-guardian/src/simcore_service_efs_guardian/services/modules/redis.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,9 @@ async def on_startup() -> None:
1515
app.state.redis_lock_client_sdk = None
1616
settings: RedisSettings = app.state.settings.EFS_GUARDIAN_REDIS
1717
redis_locks_dsn = settings.build_redis_dsn(RedisDatabase.LOCKS)
18-
app.state.redis_lock_client_sdk = lock_client = RedisClientSDK(
18+
app.state.redis_lock_client_sdk = RedisClientSDK(
1919
redis_locks_dsn, client_name=APP_NAME
2020
)
21-
await lock_client.setup()
2221

2322
async def on_shutdown() -> None:
2423
redis_lock_client_sdk: None | RedisClientSDK = app.state.redis_lock_client_sdk

services/resource-usage-tracker/src/simcore_service_resource_usage_tracker/services/modules/redis.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,9 @@ async def on_startup() -> None:
2121
app.state.redis_client_sdk = None
2222
settings: RedisSettings = app.state.settings.RESOURCE_USAGE_TRACKER_REDIS
2323
redis_locks_dsn = settings.build_redis_dsn(RedisDatabase.LOCKS)
24-
app.state.redis_client_sdk = client = RedisClientSDK(
24+
app.state.redis_client_sdk = RedisClientSDK(
2525
redis_locks_dsn, client_name=APP_NAME
2626
)
27-
await client.setup()
2827

2928
async def on_shutdown() -> None:
3029
with log_context(

services/storage/src/simcore_service_storage/redis.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ async def _setup(app: web.Application):
2424
app[_APP_REDIS_KEY] = client = RedisClientSDK(
2525
redis_locks_dsn, client_name=APP_NAME
2626
)
27-
await client.setup()
2827

2928
yield
3029

0 commit comments

Comments
 (0)