Fix/simcore sdk error messages (#2226)

* Fix on simcore_sdk error message to avoid '\n'
* Bump simcore-sdk version: 0.3.1 → 0.3.2

Author: pcrespov

packages/simcore-sdk/setup.cfg

@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 0.3.1
+current_version = 0.3.2
 commit = True
 tag = False
 

packages/simcore-sdk/setup.py

@@ -24,7 +24,7 @@ def read_reqs(reqs_path: Path):
 
 setup(
     name="simcore-sdk",
-    version="0.3.1",
+    version="0.3.2",
     packages=find_packages(where="src"),
     package_dir={"": "src"},
     python_requires=">=3.6",

packages/simcore-sdk/src/simcore_sdk/__init__.py

@@ -2,4 +2,4 @@
 
 """
 
-__version__ = "0.3.1"
+__version__ = "0.3.2"

packages/simcore-sdk/src/simcore_sdk/node_ports/exceptions.py

@@ -1,3 +1,10 @@
+# Errors raised by node_ports module as NodeportsException
+#
+#
+#  NOTE: Error message SHALL explain the reason for the error and it is prefered in one line, i.e. avoid '\n' in message
+#
+#
+
 from typing import Optional
 
 
@@ -48,7 +55,7 @@ class InvalidProtocolError(NodeportsException):
     """Invalid protocol used"""
 
     def __init__(self, dct, msg: Optional[str] = None):
-        super().__init__(f"Invalid protocol used: {dct}\n{msg}")
+        super().__init__(f"Invalid protocol used: {dct} [{msg}]")
         self.dct = dct
 
 

packages/simcore-sdk/src/simcore_sdk/node_ports/filemanager.py

@@ -5,7 +5,7 @@
 import warnings
 from contextlib import contextmanager
 from pathlib import Path
-from typing import Optional, Tuple
+from typing import Optional, Tuple, Union
 
 import aiofiles
 from aiohttp import ClientPayloadError, ClientSession, ClientTimeout
@@ -69,14 +69,21 @@ def api_client():
         del client
 
 
-def _handle_api_exception(store_id: str, err: ApiException):
+def _handle_api_exception(store_id: Union[int, str], err: ApiException):
+    """ Maps client's ApiException -> NodeportsException """
+
+    #  NOTE: ApiException produces a long __str__ with multiple lines which is not
+    #  allowed when composing header
+    #  SEE https://github.com/tornadoweb/tornado/blob/master/tornado/http1connection.py#L456
+    error_reason: str = err.reason.replace("\n", "-")
+
     if err.status > 399 and err.status < 500:
         # something invalid
-        raise exceptions.StorageInvalidCall(err)
+        raise exceptions.StorageInvalidCall(error_reason)
     if err.status > 499:
         # something went bad inside the storage server
-        raise exceptions.StorageServerIssue(err)
-    raise exceptions.StorageConnectionError(store_id, err)
+        raise exceptions.StorageServerIssue(error_reason)
+    raise exceptions.StorageConnectionError(store_id, error_reason)
 
 
 async def _get_location_id_from_location_name(store: str, api: UsersApi):