@pcrespov review: added more auto validation

Author: sanderegg

packages/models-library/src/models_library/projects_state.py

@@ -71,6 +71,19 @@ def check_not_null(v, values):
             raise ValueError("value cannot be None when project is locked")
         return v
 
+    @validator("status", always=True)
+    @classmethod
+    def check_status_compatible(v, values):
+        if values["value"] is False and v not in ["CLOSED", "OPENED"]:
+            raise ValueError(
+                f"status is set to {v} and lock is set to {values['value']}!"
+            )
+        if values["value"] is True and v == "CLOSED":
+            raise ValueError(
+                f"status is set to {v} and lock is set to {values['value']}!"
+            )
+        return v
+
 
 class ProjectRunningState(BaseModel):
     value: RunningState = Field(

packages/models-library/tests/test_projects_state.py

@@ -18,3 +18,18 @@ def test_projects_state_model_examples(model_cls, model_cls_examples):
 def test_project_locked_with_missing_owner_raises():
     with pytest.raises(ValueError):
         ProjectLocked(**{"value": True, "status": ProjectStatus.OPENED})
+    ProjectLocked(**{"value": False, "status": ProjectStatus.OPENED})
+
+
+@pytest.mark.parametrize(
+    "lock, status",
+    [
+        (False, x)
+        for x in ProjectStatus
+        if x not in [ProjectStatus.CLOSED, ProjectStatus.OPENED]
+    ]
+    + [(True, ProjectStatus.CLOSED)],
+)
+def test_project_locked_with_allowed_values(lock: bool, status: ProjectStatus):
+    with pytest.raises(ValueError):
+        ProjectLocked(**{"value": lock, "status": status})