full coverage models

Author: pcrespov

services/web/server/tests/unit/isolated/test_products_model.py

@@ -13,20 +13,29 @@
 import simcore_service_webserver.products
 import sqlalchemy as sa
 from faker import Faker
+from models_library.basic_regex import TWILIO_ALPHANUMERIC_SENDER_ID_RE
 from models_library.products import ProductName
-from pydantic import BaseModel
+from pydantic import BaseModel, ValidationError
 from pytest_simcore.helpers.faker_factories import random_product
 from pytest_simcore.pydantic_models import (
     assert_validation_model,
     walk_model_examples_in_package,
 )
 from simcore_postgres_database.models.products import products as products_table
-from simcore_service_webserver.constants import FRONTEND_APP_DEFAULT
-from simcore_service_webserver.products._models import Product
+from simcore_service_webserver.constants import (
+    FRONTEND_APP_DEFAULT,
+    FRONTEND_APPS_AVAILABLE,
+)
+from simcore_service_webserver.products.models import Product
 from sqlalchemy import String
 from sqlalchemy.dialects import postgresql
 
 
+@pytest.fixture(scope="session")
+def product_name() -> ProductName:
+    return ProductName(FRONTEND_APP_DEFAULT)
+
+
 @pytest.mark.parametrize(
     "model_cls, example_name, example_data",
     chain(walk_model_examples_in_package(simcore_service_webserver.products)),
@@ -109,43 +118,82 @@ def test_product_host_regex_with_spaces():
     assert product.support_email == "[email protected]"
 
 
-@pytest.fixture(scope="session")
-def product_name() -> ProductName:
-    return ProductName(FRONTEND_APP_DEFAULT)
+@pytest.fixture
+def fake_product_from_db(faker: Faker, product_name: ProductName) -> dict[str, Any]:
+    server_defaults = {}
+    for c in products_table.columns:
+        if c.server_default is not None:
+            if isinstance(c.type, String):
+                server_defaults[c.name] = c.server_default.arg
+            elif isinstance(c.type, postgresql.JSONB):
+                m = re.match(r"^'(.+)'::jsonb$", c.server_default.arg.text)
+                if m:
+                    server_defaults[c.name] = json.loads(m.group(1))
+    return random_product(
+        name=product_name,
+        fake=faker,
+        **server_defaults,
+    )
 
 
 def test_safe_load_empty_blanks_on_string_cols_from_db(
-    faker: Faker, product_name: ProductName
+    fake_product_from_db: dict[str, Any]
 ):
-    def _get_server_defaults():
-        server_defaults = {}
-        for c in products_table.columns:
-            if c.server_default is not None:
-                if isinstance(c.type, String):
-                    server_defaults[c.name] = c.server_default.arg
-                elif isinstance(c.type, postgresql.JSONB):
-                    m = re.match(r"^'(.+)'::jsonb$", c.server_default.arg.text)
-                    if m:
-                        server_defaults[c.name] = json.loads(m.group(1))
-
-        return server_defaults
-
     nullable_strings_column_names = [
         c.name
         for c in products_table.columns
         if isinstance(c.type, sa.String) and c.nullable
     ]
 
-    server_defaults = _get_server_defaults()
-
-    product_row_from_db = random_product(
-        name=product_name,
-        fake=faker,
-        **{name: " " * len(name) for name in nullable_strings_column_names}
+    fake_product_from_db.update(
+        {name: " " * len(name) for name in nullable_strings_column_names}
     )
 
-    product = Product.model_validate(product_row_from_db)
+    product = Product.model_validate(fake_product_from_db)
 
     assert product.model_dump(include=set(nullable_strings_column_names)) == {
         name: None for name in nullable_strings_column_names
     }
+
+
+@pytest.mark.parametrize("product_name", list(FRONTEND_APPS_AVAILABLE))
+def test_product_name_needs_front_end(
+    product_name: ProductName, fake_product_from_db: dict[str, Any]
+):
+    fake_product_from_db.update(name=product_name)
+    product = Product.model_validate(fake_product_from_db)
+    assert product.name == product_name
+
+
+def test_product_name_invalid(fake_product_from_db: dict[str, Any]):
+    # Test with an invalid name
+    fake_product_from_db.update(name="invalid name")
+    with pytest.raises(ValidationError):
+        Product.model_validate(fake_product_from_db)
+
+
+def test_twilio_sender_id_is_truncated(fake_product_from_db: dict[str, Any]):
+    fake_product_from_db.update(short_name=None, display_name="very long name" * 12)
+    product = Product.model_validate(fake_product_from_db)
+
+    assert re.match(
+        TWILIO_ALPHANUMERIC_SENDER_ID_RE, product.twilio_alpha_numeric_sender_id
+    )
+
+
+def test_template_names_from_file(fake_product_from_db: dict[str, Any]):
+    fake_product_from_db.update(registration_email_template="some_template_name_id")
+    product = Product.model_validate(fake_product_from_db)
+
+    assert (
+        product.get_template_name_for(filename="registration_email.jinja2")
+        == "some_template_name_id"
+    )
+    assert product.get_template_name_for(filename="other_template.jinja2") is None
+
+    fake_product_from_db.update(registration_email_template=None)
+    product = Product.model_validate(fake_product_from_db)
+    assert (
+        product.get_template_name_for(filename="registration_email_template.jinja2")
+        is None
+    )