Skip to content

Commit e2c3795

Browse files
committed
rm unused validation
1 parent 1a322be commit e2c3795

File tree

1 file changed

+1
-21
lines changed
  • services/storage/src/simcore_service_storage/modules/celery

1 file changed

+1
-21
lines changed

services/storage/src/simcore_service_storage/modules/celery/models.py

+1-21
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from enum import StrEnum, auto
2-
from typing import Any, Final, Protocol, Self, TypeAlias
2+
from typing import Any, Final, Protocol, TypeAlias
33
from uuid import UUID
44

55
from models_library.progress_bar import ProgressReport
@@ -56,26 +56,6 @@ class TaskStatus(BaseModel):
5656
def is_done(self) -> bool:
5757
return self.task_state in _TASK_DONE
5858

59-
# @model_validator(mode="after") This does not work MB
60-
def _check_consistency(self) -> Self:
61-
value = self.progress_report.actual_value
62-
min_value = 0.0
63-
max_value = self.progress_report.total
64-
65-
valid_states = {
66-
TaskState.PENDING: value == min_value,
67-
TaskState.RUNNING: min_value <= value <= max_value,
68-
TaskState.SUCCESS: value == max_value,
69-
TaskState.ABORTED: value == max_value,
70-
TaskState.ERROR: value == max_value,
71-
}
72-
73-
if not valid_states.get(self.task_state, True):
74-
msg = f"Inconsistent progress actual value for state={self.task_state}: {value}"
75-
raise ValueError(msg)
76-
77-
return self
78-
7959

8060
class TaskError(BaseModel):
8161
exc_type: str

0 commit comments

Comments
 (0)