Skip to content

Commit e970143

Browse files
Add licensing endpoints to api check and improve backwards compatibility checks (#7157)
1 parent a1614e8 commit e970143

File tree

4 files changed

+713
-19
lines changed

4 files changed

+713
-19
lines changed

.github/workflows/ci-testing-pull-request.yml

+6-4
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,15 @@ jobs:
3131
enable-cache: false
3232
- name: checkout source branch
3333
uses: actions/checkout@v4
34-
- name: Regenerate specs and check
34+
- name: Generate openapi specs
3535
run: |
3636
make devenv
3737
source .venv/bin/activate
3838
make openapi-specs
39+
- name: Check openapi specs are up to date
40+
run: |
3941
if ! ./ci/github/helpers/openapi-specs-diff.bash diff \
40-
https://raw.githubusercontent.com/${{ github.event.pull_request.head.repo.full_name }}/refs/heads/${{ github.event.pull_request.head.ref }} \
42+
https://raw.githubusercontent.com/${{ github.event.pull_request.head.repo.full_name }}/${{ github.event.after }} \
4143
.; then \
4244
echo "::error:: OAS are not up to date. Run 'make openapi-specs' to update them"; exit 1; \
4345
fi
@@ -57,7 +59,7 @@ jobs:
5759
- name: check api-server backwards compatibility
5860
run: |
5961
./scripts/openapi-diff.bash breaking --fail-on ERR\
60-
https://raw.githubusercontent.com/${{ github.event.pull_request.base.repo.full_name }}/refs/heads/${{ github.event.pull_request.base.ref }}/services/api-server/openapi.json \
62+
https://raw.githubusercontent.com/${{ github.event.pull_request.base.repo.full_name }}/${{ github.event.after }}/services/api-server/openapi.json \
6163
/specs/services/api-server/openapi.json
6264
6365
all-oas-breaking:
@@ -76,5 +78,5 @@ jobs:
7678
- name: Check openapi-specs backwards compatibility
7779
run: |
7880
./ci/github/helpers/openapi-specs-diff.bash breaking \
79-
https://raw.githubusercontent.com/${{ github.event.pull_request.base.repo.full_name }}/refs/heads/${{ github.event.pull_request.base.ref }} \
81+
https://raw.githubusercontent.com/${{ github.event.pull_request.base.repo.full_name }}/${{ github.event.after }} \
8082
.

0 commit comments

Comments
 (0)