Skip to content

Commit f29dc89

Browse files
GitHKAndrei Neagu
and
Andrei Neagu
authored
🐛 Fix issue with sending metrics that are None to Prometheus (#6951)
Co-authored-by: Andrei Neagu <[email protected]>
1 parent c0df260 commit f29dc89

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_events_user_services.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -237,9 +237,9 @@ async def progress_create_containers(
237237
start_duration = (
238238
scheduler_data.dynamic_sidecar.instrumentation.elapsed_since_start_request()
239239
)
240-
assert start_duration is not None # nosec
241-
get_instrumentation(app).dynamic_sidecar_metrics.start_time_duration.labels(
242-
**get_metrics_labels(scheduler_data)
243-
).observe(start_duration)
240+
if start_duration is not None:
241+
get_instrumentation(app).dynamic_sidecar_metrics.start_time_duration.labels(
242+
**get_metrics_labels(scheduler_data)
243+
).observe(start_duration)
244244

245245
_logger.info("Internal state after creating user services %s", scheduler_data)

services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_events_utils.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -385,10 +385,10 @@ async def attempt_pod_removal_and_data_saving(
385385
stop_duration = (
386386
scheduler_data.dynamic_sidecar.instrumentation.elapsed_since_close_request()
387387
)
388-
assert stop_duration is not None # nosec
389-
get_instrumentation(app).dynamic_sidecar_metrics.stop_time_duration.labels(
390-
**get_metrics_labels(scheduler_data)
391-
).observe(stop_duration)
388+
if stop_duration is not None:
389+
get_instrumentation(app).dynamic_sidecar_metrics.stop_time_duration.labels(
390+
**get_metrics_labels(scheduler_data)
391+
).observe(stop_duration)
392392

393393

394394
async def attach_project_networks(app: FastAPI, scheduler_data: SchedulerData) -> None:

0 commit comments

Comments
 (0)