Skip to content

Commit f7e3e86

Browse files
🐛 Update webserver's swagger ui (#6971)
1 parent 8f4c1b2 commit f7e3e86

File tree

4 files changed

+16
-44
lines changed

4 files changed

+16
-44
lines changed

services/web/server/requirements/_base.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ aiohttp
2727
aiohttp_jinja2
2828
aiohttp_security
2929
aiohttp_session[secure]
30-
aiohttp-swagger[performance]
3130
aiopg[sa] # db
3231
aiosmtplib # email
3332
asyncpg # db
@@ -50,5 +49,6 @@ pydantic[email] # models
5049
python-magic # excel
5150
python-socketio # web-sockets
5251
redis
52+
swagger-ui-py
5353
tenacity
5454
twilio

services/web/server/requirements/_base.txt

Lines changed: 5 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -61,15 +61,12 @@ aiohttp==3.8.5
6161
# aiohttp-jinja2
6262
# aiohttp-security
6363
# aiohttp-session
64-
# aiohttp-swagger
6564
aiohttp-jinja2==1.5
6665
# via -r requirements/_base.in
6766
aiohttp-security==0.4.0
6867
# via -r requirements/_base.in
6968
aiohttp-session==2.11.0
7069
# via -r requirements/_base.in
71-
aiohttp-swagger==1.0.16
72-
# via -r requirements/_base.in
7370
aiopg==1.4.0
7471
# via
7572
# -r requirements/../../../../packages/service-library/requirements/_aiohttp.in
@@ -269,7 +266,7 @@ jinja2==3.1.2
269266
# -c requirements/../../../../packages/simcore-sdk/requirements/../../../requirements/constraints.txt
270267
# -c requirements/../../../../requirements/constraints.txt
271268
# aiohttp-jinja2
272-
# aiohttp-swagger
269+
# swagger-ui-py
273270
json2html==1.3.0
274271
# via -r requirements/_base.in
275272
jsondiff==2.0.0
@@ -473,6 +470,7 @@ packaging==24.1
473470
# -r requirements/../../../../packages/simcore-sdk/requirements/_base.in
474471
# -r requirements/_base.in
475472
# gunicorn
473+
# swagger-ui-py
476474
pamqp==3.2.1
477475
# via aiormq
478476
passlib==1.7.4
@@ -651,7 +649,7 @@ pyyaml==6.0.1
651649
# -c requirements/../../../../requirements/constraints.txt
652650
# -r requirements/../../../../packages/service-library/requirements/_base.in
653651
# -r requirements/../../../../packages/simcore-sdk/requirements/../../../packages/service-library/requirements/_base.in
654-
# aiohttp-swagger
652+
# swagger-ui-py
655653
redis==5.0.4
656654
# via
657655
# -c requirements/../../../../packages/common-library/requirements/../../../requirements/constraints.txt
@@ -748,6 +746,8 @@ sqlalchemy==1.4.47
748746
# -r requirements/../../../../packages/simcore-sdk/requirements/../../../packages/postgres-database/requirements/_base.in
749747
# aiopg
750748
# alembic
749+
swagger-ui-py==23.9.23
750+
# via -r requirements/_base.in
751751
tenacity==8.5.0
752752
# via
753753
# -r requirements/../../../../packages/service-library/requirements/_base.in
@@ -783,37 +783,6 @@ typing-extensions==4.12.2
783783
# pydantic
784784
# pydantic-core
785785
# typer
786-
ujson==5.5.0
787-
# via
788-
# -c requirements/../../../../packages/common-library/requirements/../../../requirements/constraints.txt
789-
# -c requirements/../../../../packages/models-library/requirements/../../../packages/common-library/requirements/../../../requirements/constraints.txt
790-
# -c requirements/../../../../packages/models-library/requirements/../../../requirements/constraints.txt
791-
# -c requirements/../../../../packages/postgres-database/requirements/../../../packages/common-library/requirements/../../../requirements/constraints.txt
792-
# -c requirements/../../../../packages/postgres-database/requirements/../../../requirements/constraints.txt
793-
# -c requirements/../../../../packages/service-library/requirements/../../../packages/common-library/requirements/../../../requirements/constraints.txt
794-
# -c requirements/../../../../packages/service-library/requirements/../../../packages/models-library/requirements/../../../packages/common-library/requirements/../../../requirements/constraints.txt
795-
# -c requirements/../../../../packages/service-library/requirements/../../../packages/models-library/requirements/../../../requirements/constraints.txt
796-
# -c requirements/../../../../packages/service-library/requirements/../../../packages/settings-library/requirements/../../../packages/common-library/requirements/../../../requirements/constraints.txt
797-
# -c requirements/../../../../packages/service-library/requirements/../../../packages/settings-library/requirements/../../../requirements/constraints.txt
798-
# -c requirements/../../../../packages/service-library/requirements/../../../requirements/constraints.txt
799-
# -c requirements/../../../../packages/settings-library/requirements/../../../packages/common-library/requirements/../../../requirements/constraints.txt
800-
# -c requirements/../../../../packages/settings-library/requirements/../../../requirements/constraints.txt
801-
# -c requirements/../../../../packages/simcore-sdk/requirements/../../../packages/common-library/requirements/../../../requirements/constraints.txt
802-
# -c requirements/../../../../packages/simcore-sdk/requirements/../../../packages/models-library/requirements/../../../packages/common-library/requirements/../../../requirements/constraints.txt
803-
# -c requirements/../../../../packages/simcore-sdk/requirements/../../../packages/models-library/requirements/../../../requirements/constraints.txt
804-
# -c requirements/../../../../packages/simcore-sdk/requirements/../../../packages/postgres-database/requirements/../../../packages/common-library/requirements/../../../requirements/constraints.txt
805-
# -c requirements/../../../../packages/simcore-sdk/requirements/../../../packages/postgres-database/requirements/../../../requirements/constraints.txt
806-
# -c requirements/../../../../packages/simcore-sdk/requirements/../../../packages/service-library/requirements/../../../packages/common-library/requirements/../../../requirements/constraints.txt
807-
# -c requirements/../../../../packages/simcore-sdk/requirements/../../../packages/service-library/requirements/../../../packages/models-library/requirements/../../../packages/common-library/requirements/../../../requirements/constraints.txt
808-
# -c requirements/../../../../packages/simcore-sdk/requirements/../../../packages/service-library/requirements/../../../packages/models-library/requirements/../../../requirements/constraints.txt
809-
# -c requirements/../../../../packages/simcore-sdk/requirements/../../../packages/service-library/requirements/../../../packages/settings-library/requirements/../../../packages/common-library/requirements/../../../requirements/constraints.txt
810-
# -c requirements/../../../../packages/simcore-sdk/requirements/../../../packages/service-library/requirements/../../../packages/settings-library/requirements/../../../requirements/constraints.txt
811-
# -c requirements/../../../../packages/simcore-sdk/requirements/../../../packages/service-library/requirements/../../../requirements/constraints.txt
812-
# -c requirements/../../../../packages/simcore-sdk/requirements/../../../packages/settings-library/requirements/../../../packages/common-library/requirements/../../../requirements/constraints.txt
813-
# -c requirements/../../../../packages/simcore-sdk/requirements/../../../packages/settings-library/requirements/../../../requirements/constraints.txt
814-
# -c requirements/../../../../packages/simcore-sdk/requirements/../../../requirements/constraints.txt
815-
# -c requirements/../../../../requirements/constraints.txt
816-
# aiohttp-swagger
817786
urllib3==2.2.3
818787
# via
819788
# -c requirements/../../../../packages/common-library/requirements/../../../requirements/constraints.txt

services/web/server/src/simcore_service_webserver/rest/plugin.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@
99
import logging
1010

1111
from aiohttp import web
12-
from aiohttp_swagger import setup_swagger # type: ignore[import-untyped]
1312
from servicelib.aiohttp.application_setup import ModuleCategory, app_module_setup
1413
from servicelib.aiohttp.rest_middlewares import (
1514
envelope_middleware_factory,
1615
error_middleware_factory,
1716
)
17+
from swagger_ui import api_doc # type: ignore
1818

1919
from .._meta import API_VTAG
2020
from ..security.plugin import setup_security
@@ -60,11 +60,11 @@ def setup_rest(app: web.Application):
6060
#
6161
_logger.debug("OAS loaded from %s ", spec_path)
6262
if settings.REST_SWAGGER_API_DOC_ENABLED:
63-
setup_swagger(
64-
app,
65-
swagger_url="/dev/doc",
66-
swagger_from_file=str(spec_path),
67-
ui_version=3,
63+
api_doc(
64+
app=app,
65+
url_prefix="/dev/doc",
66+
config_path=str(spec_path),
67+
title="Web-API doc",
6868
)
6969

7070

services/web/server/tests/unit/isolated/test_diagnostics.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
from unittest.mock import Mock
77

88
import pytest
9+
from pytest_mock import MockerFixture
910
from servicelib.aiohttp.application_setup import APP_SETUP_COMPLETED_KEY
1011
from simcore_service_webserver.application_settings import setup_settings
1112
from simcore_service_webserver.diagnostics.plugin import setup_diagnostics
@@ -35,12 +36,14 @@ def add_routes(self, *args, **kwargs):
3536

3637

3738
@pytest.fixture
38-
def app_mock():
39+
def app_mock(mocker: MockerFixture):
3940
app = MockApp()
4041

4142
# emulates security is initialized
4243
app[APP_SETUP_COMPLETED_KEY] = ["simcore_service_webserver.security"]
4344

45+
mocker.patch("simcore_service_webserver.rest.plugin.api_doc")
46+
4447
return app
4548

4649

0 commit comments

Comments
 (0)