Skip to content

code deprecation after #4697 reaches production #4745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GitHK opened this issue Sep 13, 2023 · 0 comments · Fixed by #6216
Closed

code deprecation after #4697 reaches production #4745

GitHK opened this issue Sep 13, 2023 · 0 comments · Fixed by #6216
Assignees

Comments

@GitHK
Copy link
Contributor

GitHK commented Sep 13, 2023

After PR #4697 is released in production the following legacy compatibility changes can be made.

SharedStore legacy format updates

Inside services/dynamic-sidecar/tests/unit/test_models_shared_store.py remove following block:

    # remove properties which have been added but did not exit
    # when the legacy format was created
    # NOTE this was already parsed so this check is a regression
    # to check compatibility with very old formats
    parsed_legacy_format.pop("original_to_container_names")

Inside services/dynamic-sidecar/tests/mocks/legacy_shared_store.json extend the legacy json with "original_to_container_names": {}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant