-
Notifications
You must be signed in to change notification settings - Fork 29
add hook to notify user services when inputs have been pulled #6407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for this proposal. It sounds lot of work from your side and not easy at all from the users' perspective. |
Please note this is intended to be used when you expect inputs to change at runtime. Not before service start. For that there is a different proposal #6406 This is actually the "easy" solution for the user. Also form a backend perspective. |
I also find this to be much less urgent than the other proposal. And also a service has multiple input ports, so you cannot have a global hook, it would need to be per port. Also, stupid question, could we not download the zip file into a temporary folder and move all its contents in "almost" one shot in the final folder? |
per port hooks are tricky with our current system, as our hook system does not allow to push arguments to the container, it's more like a "signal". Currently only: "some inputs started downloading" and "some inputs finished downloading" can be provided.
File is already downloaded in a temporary folder, it is unzipped in the target folder though. Since
Yes users at this point know exactly where they have the files, so they just need to know when it is safe to open them. I also agree, that this case is not high priority |
I would like to revise your proposed API a bit before actually moving towards implementing this. I think there can be some improvements if we think this through deeply in a group. I specifically think that first a visual indication in the e.g. osparc-gui around the iframe to show when inputs have changed or are changing (yello light or so or loading bar whatever) is much more useful for most users, all non-power-users, and power-users like werner have anyway already built functionality to handle this client-side. |
Detecting when inputs are done pulling at runtime is hard fo the users for different reasons.
In order to simplify the user's life the following proposal is made.
Services can define two new additional "hooks":
-
inputs_pulling_started
an event which signals the start of inputs pulling to the users-
inputs_pulling_finished
an event which signals the end of inputs pulling to the usersWith these two events the user can implement their require logic in much more reliable way. An issue still remains with the simplicity of doing so.
in order to further aid the users the following additional proposal is made.
The oSPARC team creates a utility package to help the user. It will be used like this:
/osparc-utils/inputs-monitor
inputs_pulling_started
"hook" on the service label and connect it to/osparc-utils/inputs-monitor/inputs_pulling_started.sh
scriptinputs_pulling_finished
"hook" on the service label and connect it to/osparc-utils/inputs-monitor/inputs_pulling_finisheds.sh
script/osparc-utils/inputs-monitor/get_version.sh
which returns a string repressing the last version/osparc-utils/inputs-monitor/get_version.sh
will return a different version string.The text was updated successfully, but these errors were encountered: