re-enable LQ tests

Author: lkdvos

Project.toml

@@ -24,7 +24,7 @@ BlockArrays = "1.2.0"
 EllipsisNotation = "1.8.0"
 GradedUnitRanges = "0.1.0"
 LinearAlgebra = "1.10"
-MatrixAlgebraKit = "0.1.0"
+MatrixAlgebraKit = "0.1.1"
 TupleTools = "1.6.0"
 TypeParameterAccessors = "0.2.1, 0.3"
 julia = "1.10"

test/test_factorizations.jl

@@ -52,20 +52,19 @@ end
   @test size(Q, 1) == size(Q, 2) * size(Q, 3) # Q is unitary
 end
 
-# TODO: broken and segfaults because of MatrixAlgebraKit issue
-# @testset "Compact LQ ($T)" for T in elts
-#   A = randn(T, 5, 4, 3, 2) # compact only makes a difference for less rows
-#   labels_A = (:a, :b, :c, :d)
-#   labels_Q = (:d, :c)
-#   labels_L = (:b, :a)
-
-#   Acopy = deepcopy(A)
-#   L, Q = @constinferred lq(A, labels_A, labels_L, labels_Q; full=false)
-#   @test A == Acopy # should not have altered initial array
-#   A′ = contract(labels_A, L, (labels_L..., :q), Q, (:q, labels_Q...))
-#   @test A ≈ A′
-#   @test size(Q, 1) == min(size(A, 1) * size(A, 2), size(A, 3) * size(A, 4)) # Q is unitary
-# end
+@testset "Compact LQ ($T)" for T in elts
+  A = randn(T, 5, 4, 3, 2) # compact only makes a difference for less rows
+  labels_A = (:a, :b, :c, :d)
+  labels_Q = (:d, :c)
+  labels_L = (:b, :a)
+
+  Acopy = deepcopy(A)
+  L, Q = @constinferred lq(A, labels_A, labels_L, labels_Q; full=false)
+  @test A == Acopy # should not have altered initial array
+  A′ = contract(labels_A, L, (labels_L..., :q), Q, (:q, labels_Q...))
+  @test A ≈ A′
+  @test size(Q, 1) == min(size(A, 1) * size(A, 2), size(A, 3) * size(A, 4)) # Q is unitary
+end
 
 # Eigenvalue Decomposition
 # ------------------------