Skip to content

Automate calling convention testing #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PathogenDavid opened this issue Sep 10, 2020 · 3 comments
Closed

Automate calling convention testing #32

PathogenDavid opened this issue Sep 10, 2020 · 3 comments
Labels
Area-OutputGeneration Issues concerning the process of generating output from Biohazrd Concept-Correctness Issues concerning the correctness of the translation from an ABI perspective Concept-OutputUsability Issues concerning whether or not the output from Biohazrd is actually usable

Comments

@PathogenDavid
Copy link
Member

PathogenDavid commented Sep 10, 2020 •
edited
Loading

A medium/long-term goal of Biohazrd is to automate verification of the calling convention to ensure that everything is kosher across the entire API surface.
@PathogenDavid PathogenDavid mentioned this issue Sep 10, 2020
Open
@PathogenDavid
Copy link
Member Author

We should consider testing behavior of exceptions thrown from virtual methods implemented from C#? If anything but just so we can make some guarantees about how how they work. (If memory serves, they work fine on Windows but are problematic on Linux. Not sure if that's still entirely true.)

@PathogenDavid
Copy link
Member Author

This should also take into consideration CI needs.

@PathogenDavid PathogenDavid added Area-OutputGeneration Issues concerning the process of generating output from Biohazrd Area-Verification Issues concerning verification of the model before output generation Concept-Correctness Issues concerning the correctness of the translation from an ABI perspective Concept-OutputUsability Issues concerning whether or not the output from Biohazrd is actually usable and removed Area-Verification Issues concerning verification of the model before output generation labels Sep 21, 2020
@PathogenDavid PathogenDavid mentioned this issue Oct 10, 2020
Closed
@PathogenDavid PathogenDavid mentioned this issue Feb 9, 2021
Closed
@PathogenDavid
Copy link
Member Author

In practice this has not been a problem in a very long time so I don't think it would be worth the effort here. In the long run any concerns here will mostly be covered by manually-authored integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-OutputGeneration Issues concerning the process of generating output from Biohazrd Concept-Correctness Issues concerning the correctness of the translation from an ABI perspective Concept-OutputUsability Issues concerning whether or not the output from Biohazrd is actually usable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PathogenDavid