Skip to content

Commit f9ca96b

Browse files
author
Diptorup Deb
authored
Merge pull request #1113 from IntelPython/remove/github_build_for_py38
Do not build for python 3.8 in Github CI
2 parents 25fb36f + c608d23 commit f9ca96b

File tree

4 files changed

+6
-23
lines changed

4 files changed

+6
-23
lines changed

.github/workflows/conda-package.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
strategy:
2727
fail-fast: false
2828
matrix:
29-
python: ['3.8', '3.9', '3.10']
29+
python: ['3.9', '3.10']
3030
os: [ubuntu-latest, windows-latest]
3131

3232
runs-on: ${{ matrix.os }}
@@ -93,7 +93,7 @@ jobs:
9393
strategy:
9494
fail-fast: false
9595
matrix:
96-
python: ['3.8', '3.9', '3.10']
96+
python: ['3.9', '3.10']
9797
os: [ubuntu-20.04, ubuntu-latest, windows-latest]
9898
experimental: [false]
9999

@@ -199,7 +199,7 @@ jobs:
199199

200200
strategy:
201201
matrix:
202-
python: ['3.8', '3.9', '3.10']
202+
python: ['3.9', '3.10']
203203
os: [ubuntu-latest, windows-latest]
204204

205205
runs-on: ${{ matrix.os }}

.github/workflows/docker.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ on:
2222
oneapi_version:
2323
default: '2023.1.0.46401'
2424
python_versions:
25-
default: '["3.8", "3.9", "3.10", "3.11"]'
25+
default: '["3.9", "3.10", "3.11"]'
2626
buildkit_version:
2727
default: '0.11.6'
2828

build-environment.yml

Lines changed: 0 additions & 9 deletions
This file was deleted.

numba_dpex/core/runtime/_nrt_python_helper.c

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -170,20 +170,12 @@ PyTypeObject MemInfoType = {
170170
* https://github.com/python/cpython/blob/d917cfe4051d45b2b755c726c096ecfcc4869ceb/Include/cpython/object.h#L257
171171
*/
172172
0, /* tp_vectorcall */
173-
#if (PY_MAJOR_VERSION == 3) && (PY_MINOR_VERSION == 8)
174-
/* This is Python 3.8 only.
175-
* See: https://github.com/python/cpython/blob/3.8/Include/cpython/object.h
176-
* there's a tp_print preserved for backwards compatibility. xref:
177-
* https://github.com/python/cpython/blob/d917cfe4051d45b2b755c726c096ecfcc4869ceb/Include/cpython/object.h#L260
178-
*/
179-
0, /* tp_print */
180-
#endif
181173

182174
/* WARNING: Do not remove this, only modify it! It is a version guard to
183175
* act as a reminder to update this struct on Python version update! */
184176
#if (PY_MAJOR_VERSION == 3)
185-
#if !((PY_MINOR_VERSION == 8) || (PY_MINOR_VERSION == 9) || \
186-
(PY_MINOR_VERSION == 10) || (PY_MINOR_VERSION == 11))
177+
#if !((PY_MINOR_VERSION == 9) || (PY_MINOR_VERSION == 10) || \
178+
(PY_MINOR_VERSION == 11))
187179
#error "Python minor version is not supported."
188180
#endif
189181
#else

0 commit comments

Comments
 (0)