Merge pull request #4344 from input-output-hk/mpj/remove-data-valiation

Remove unnecessary validation of Data

Author: newhoggy

cardano-api/src/Cardano/Api/ScriptData.hs

@@ -246,13 +246,12 @@ validateScriptData d =
       []    -> Right ()
       err:_ -> Left err
   where
-    -- collect all errors in a monoidal fold style:
-    collect (ScriptDataNumber n) =
-        [ ScriptDataNumberOutOfRange n
-        |    n >         fromIntegral (maxBound :: Word64)
-          || n < negate (fromIntegral (maxBound :: Word64))
-        ]
-    collect ScriptDataBytes{} = []
+    -- Arbitrary size numbers are fine
+    collect (ScriptDataNumber _) = []
+
+    -- Arbitrary sized bytes are fine
+    collect (ScriptDataBytes _) = []
+
     collect (ScriptDataList xs) =
         foldMap collect xs
 
@@ -261,36 +260,28 @@ validateScriptData d =
                          <> collect v)
                 kvs
 
+    -- Constr tags do need to be less than a Word64
     collect (ScriptDataConstructor n xs) =
         [ ScriptDataConstructorOutOfRange n
         | n > fromIntegral (maxBound :: Word64) || n < 0 ]
      <> foldMap collect xs
 
 -- | An error in script data due to an out-of-range value.
 --
-data ScriptDataRangeError =
-
-    -- | The number is outside the maximum range of @-2^64-1 .. 2^64-1@.
-    --
-    ScriptDataNumberOutOfRange !Integer
+newtype ScriptDataRangeError =
 
     -- | The number is outside the maximum range of @-2^64-1 .. 2^64-1@.
     --
-  | ScriptDataConstructorOutOfRange !Integer
+  ScriptDataConstructorOutOfRange Integer
   deriving (Eq, Show)
 
 instance Error ScriptDataRangeError where
-  displayError (ScriptDataNumberOutOfRange n) =
-      "Number in script data value "
-        <> show n
-        <> " is outside the range -(2^64-1) .. 2^64-1."
   displayError (ScriptDataConstructorOutOfRange n) =
       "Constructor numbers in script data value "
         <> show n
         <> " is outside the range 0 .. 2^64-1."
 
 
-
 -- ----------------------------------------------------------------------------
 -- JSON conversion
 --