Merge pull request #4408 from input-output-hk/ludvikgalois/no-wit-transactions

Allow assembling transactions with no witnesses

Author: Jimbo4350

cardano-cli/ChangeLog.md

@@ -10,6 +10,7 @@
 
 - Add `query tx-mempool` ([PR 4276](https://github.com/input-output-hk/cardano-node/pull/4276))
 
+- Allow assembling transactions with no witnesses ([PR 4408](https://github.com/input-output-hk/cardano-node/pull/4408))
 
 ### Bugs
 

cardano-cli/src/Cardano/CLI/Shelley/Parsers.hs

@@ -750,7 +750,7 @@ pTransaction =
 
   pTransactionSign  :: Parser TransactionCmd
   pTransactionSign = TxSign <$> pInputTxOrTxBodyFile
-                            <*> pSomeWitnessSigningData
+                            <*> many pWitnessSigningData
                             <*> optional pNetworkId
                             <*> pTxFile Output
 
@@ -764,7 +764,7 @@ pTransaction =
   pTransactionAssembleTxBodyWit :: Parser TransactionCmd
   pTransactionAssembleTxBodyWit = TxAssembleTxBodyWitness
                                     <$> pTxBodyFile Input
-                                    <*> some pWitnessFile
+                                    <*> many pWitnessFile
                                     <*> pOutputFile
 
   pTransactionSubmit :: Parser TransactionCmd
@@ -1665,9 +1665,8 @@ pWhichLeadershipSchedule = pCurrent <|> pNext
        <> Opt.help "Get the leadership schedule for the following epoch."
        )
 
-pSomeWitnessSigningData :: Parser [WitnessSigningData]
-pSomeWitnessSigningData =
-  some $
+pWitnessSigningData :: Parser WitnessSigningData
+pWitnessSigningData =
       KeyWitnessSigningData
         <$>
           ( SigningKeyFile <$>
@@ -1691,21 +1690,6 @@ pSigningKeyFile fdir =
       <> Opt.completer (Opt.bashCompleter "file")
       )
 
-pWitnessSigningData :: Parser WitnessSigningData
-pWitnessSigningData =
-    KeyWitnessSigningData
-      <$>
-        ( SigningKeyFile <$>
-            Opt.strOption
-              (  Opt.long "signing-key-file"
-              <> Opt.metavar "FILE"
-              <> Opt.help "Filepath of the signing key to be used in witness construction."
-              <> Opt.completer (Opt.bashCompleter "file")
-              )
-        )
-      <*>
-        optional pByronAddress
-
 pKesPeriod :: Parser KESPeriod
 pKesPeriod =
   KESPeriod <$>