Skip to content

Commit f9d5445

Browse files
committed
Fix Data.Aeson.Types import
Importing it as `Data.Aeson.Types.Internal` was confusing. The Haskell convention is that module with `Internal` in the name contain unsafe functions or unstable APIs.
1 parent a5e4dd6 commit f9d5445

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

Diff for: cardano-api/src/Cardano/Api/LedgerState.hs

+9-9
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ import Control.Monad.Trans.Except
5757
import Control.Monad.Trans.Except.Extra (firstExceptT, handleIOExceptT, hoistEither, left)
5858
import Control.State.Transition
5959
import Data.Aeson as Aeson
60-
import qualified Data.Aeson.Types as Data.Aeson.Types.Internal
60+
import Data.Aeson.Types (Parser)
6161
import Data.Bifunctor
6262
import Data.ByteArray (ByteArrayAccess)
6363
import qualified Data.ByteArray
@@ -764,7 +764,7 @@ instance FromJSON NodeConfig where
764764
parseJSON v =
765765
Aeson.withObject "NodeConfig" parse v
766766
where
767-
parse :: Object -> Data.Aeson.Types.Internal.Parser NodeConfig
767+
parse :: Object -> Parser NodeConfig
768768
parse o =
769769
NodeConfig
770770
<$> o .:? "PBftSignatureThreshold"
@@ -786,47 +786,47 @@ instance FromJSON NodeConfig where
786786
<*> parseAlonzoHardForkEpoch o
787787
<*> parseBabbageHardForkEpoch o
788788

789-
parseByronProtocolVersion :: Object -> Data.Aeson.Types.Internal.Parser Cardano.Chain.Update.ProtocolVersion
789+
parseByronProtocolVersion :: Object -> Parser Cardano.Chain.Update.ProtocolVersion
790790
parseByronProtocolVersion o =
791791
Cardano.Chain.Update.ProtocolVersion
792792
<$> o .: "LastKnownBlockVersion-Major"
793793
<*> o .: "LastKnownBlockVersion-Minor"
794794
<*> o .: "LastKnownBlockVersion-Alt"
795795

796-
parseByronSoftwareVersion :: Object -> Data.Aeson.Types.Internal.Parser Cardano.Chain.Update.SoftwareVersion
796+
parseByronSoftwareVersion :: Object -> Parser Cardano.Chain.Update.SoftwareVersion
797797
parseByronSoftwareVersion o =
798798
Cardano.Chain.Update.SoftwareVersion
799799
<$> fmap Cardano.Chain.Update.ApplicationName (o .: "ApplicationName")
800800
<*> o .: "ApplicationVersion"
801801

802-
parseShelleyHardForkEpoch :: Object -> Data.Aeson.Types.Internal.Parser Consensus.TriggerHardFork
802+
parseShelleyHardForkEpoch :: Object -> Parser Consensus.TriggerHardFork
803803
parseShelleyHardForkEpoch o =
804804
asum
805805
[ Consensus.TriggerHardForkAtEpoch <$> o .: "TestShelleyHardForkAtEpoch"
806806
, pure $ Consensus.TriggerHardForkAtVersion 2 -- Mainnet default
807807
]
808808

809-
parseAllegraHardForkEpoch :: Object -> Data.Aeson.Types.Internal.Parser Consensus.TriggerHardFork
809+
parseAllegraHardForkEpoch :: Object -> Parser Consensus.TriggerHardFork
810810
parseAllegraHardForkEpoch o =
811811
asum
812812
[ Consensus.TriggerHardForkAtEpoch <$> o .: "TestAllegraHardForkAtEpoch"
813813
, pure $ Consensus.TriggerHardForkAtVersion 3 -- Mainnet default
814814
]
815815

816-
parseMaryHardForkEpoch :: Object -> Data.Aeson.Types.Internal.Parser Consensus.TriggerHardFork
816+
parseMaryHardForkEpoch :: Object -> Parser Consensus.TriggerHardFork
817817
parseMaryHardForkEpoch o =
818818
asum
819819
[ Consensus.TriggerHardForkAtEpoch <$> o .: "TestMaryHardForkAtEpoch"
820820
, pure $ Consensus.TriggerHardForkAtVersion 4 -- Mainnet default
821821
]
822822

823-
parseAlonzoHardForkEpoch :: Object -> Data.Aeson.Types.Internal.Parser Consensus.TriggerHardFork
823+
parseAlonzoHardForkEpoch :: Object -> Parser Consensus.TriggerHardFork
824824
parseAlonzoHardForkEpoch o =
825825
asum
826826
[ Consensus.TriggerHardForkAtEpoch <$> o .: "TestAlonzoHardForkAtEpoch"
827827
, pure $ Consensus.TriggerHardForkAtVersion 5 -- Mainnet default
828828
]
829-
parseBabbageHardForkEpoch :: Object -> Data.Aeson.Types.Internal.Parser Consensus.TriggerHardFork
829+
parseBabbageHardForkEpoch :: Object -> Parser Consensus.TriggerHardFork
830830
parseBabbageHardForkEpoch o =
831831
asum
832832
[ Consensus.TriggerHardForkAtEpoch <$> o .: "TestBabbageHardForkAtEpoch"

0 commit comments

Comments
 (0)