Skip to content

Implement a single testnet function in cardano-testnet #4539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #4571
Jimbo4350 opened this issue Oct 18, 2022 · 1 comment
Closed
Tracked by #4571

Implement a single testnet function in cardano-testnet #4539

Jimbo4350 opened this issue Oct 18, 2022 · 1 comment
Assignees
Labels
refactor type: internal feature Non user-facing functionality user type: internal Created by an IOG employee

Comments

@Jimbo4350
Copy link
Contributor

Jimbo4350 commented Oct 18, 2022

Currently we have four testnet functions in cardano-testnet. We should have a single testnet function defined as follows:

testnet :: TestnetOptions era -> H.Conf -> Integration TestnetRuntime

Where TestNetOptions era is defined as follows:

data TestnetOptions 
  =  ShelleyOnlyTestnetOptions ShelleyTestnetOptions  
  |  BabbageOnlyTestnetOptions BabbageTestnetOptions   
  |  CardanoTestnetOptions CardanoTestnetOptions

We can convert the current multiple definitions of TestnetOptions as is to the relevant ($era)TestnetOptions via renaming

For simplicity we will not include a Byron era data constructor because it is unlikely users will want to spin up a Byron testnet

@Jimbo4350 Jimbo4350 added enhancement New feature or request refactor and removed enhancement New feature or request labels Oct 18, 2022
@MarcFontaine
Copy link
Contributor

#4544

@CarlosLopezDeLara CarlosLopezDeLara moved this to 🏗 In progress in Node CLI/API 2022 Oct 20, 2022
@dorin100 dorin100 added type: internal feature Non user-facing functionality user type: internal Created by an IOG employee labels Oct 21, 2022
@MarcFontaine MarcFontaine moved this from 🏗 In progress to 👀Code review in Node CLI/API 2022 Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor type: internal feature Non user-facing functionality user type: internal Created by an IOG employee
Projects
None yet
Development

No branches or pull requests

3 participants