Skip to content

Commit 74f57c9

Browse files
IvanGoncharovIvanGoncharov
authored
tests: remove unnecessary returns (graphql#267)
1 parent 30339c6 commit 74f57c9

File tree

5 files changed

+45
-45
lines changed

5 files changed

+45
-45
lines changed

‎src/connection/__tests__/arrayconnection.js

+30-30
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ describe('connectionFromArray()', () => {
1717
describe('basic slicing', () => {
1818
it('returns all elements without filters', () => {
1919
const c = connectionFromArray(letters, {});
20-
return expect(c).to.deep.equal({
20+
expect(c).to.deep.equal({
2121
edges: [
2222
{
2323
node: 'A',
@@ -51,7 +51,7 @@ describe('connectionFromArray()', () => {
5151

5252
it('respects a smaller first', () => {
5353
const c = connectionFromArray(letters, { first: 2 });
54-
return expect(c).to.deep.equal({
54+
expect(c).to.deep.equal({
5555
edges: [
5656
{ node: 'A', cursor: 'YXJyYXljb25uZWN0aW9uOjA=' },
5757
{
@@ -70,7 +70,7 @@ describe('connectionFromArray()', () => {
7070

7171
it('respects an overly large first', () => {
7272
const c = connectionFromArray(letters, { first: 10 });
73-
return expect(c).to.deep.equal({
73+
expect(c).to.deep.equal({
7474
edges: [
7575
{
7676
node: 'A',
@@ -104,7 +104,7 @@ describe('connectionFromArray()', () => {
104104

105105
it('respects a smaller last', () => {
106106
const c = connectionFromArray(letters, { last: 2 });
107-
return expect(c).to.deep.equal({
107+
expect(c).to.deep.equal({
108108
edges: [
109109
{
110110
node: 'D',
@@ -126,7 +126,7 @@ describe('connectionFromArray()', () => {
126126

127127
it('respects an overly large last', () => {
128128
const c = connectionFromArray(letters, { last: 10 });
129-
return expect(c).to.deep.equal({
129+
expect(c).to.deep.equal({
130130
edges: [
131131
{
132132
node: 'A',
@@ -165,7 +165,7 @@ describe('connectionFromArray()', () => {
165165
first: 2,
166166
after: 'YXJyYXljb25uZWN0aW9uOjE=',
167167
});
168-
return expect(c).to.deep.equal({
168+
expect(c).to.deep.equal({
169169
edges: [
170170
{
171171
node: 'C',
@@ -190,7 +190,7 @@ describe('connectionFromArray()', () => {
190190
first: 10,
191191
after: 'YXJyYXljb25uZWN0aW9uOjE=',
192192
});
193-
return expect(c).to.deep.equal({
193+
expect(c).to.deep.equal({
194194
edges: [
195195
{
196196
node: 'C',
@@ -219,7 +219,7 @@ describe('connectionFromArray()', () => {
219219
last: 2,
220220
before: 'YXJyYXljb25uZWN0aW9uOjM=',
221221
});
222-
return expect(c).to.deep.equal({
222+
expect(c).to.deep.equal({
223223
edges: [
224224
{
225225
node: 'B',
@@ -244,7 +244,7 @@ describe('connectionFromArray()', () => {
244244
last: 10,
245245
before: 'YXJyYXljb25uZWN0aW9uOjM=',
246246
});
247-
return expect(c).to.deep.equal({
247+
expect(c).to.deep.equal({
248248
edges: [
249249
{
250250
node: 'A',
@@ -274,7 +274,7 @@ describe('connectionFromArray()', () => {
274274
after: 'YXJyYXljb25uZWN0aW9uOjA=',
275275
before: 'YXJyYXljb25uZWN0aW9uOjQ=',
276276
});
277-
return expect(c).to.deep.equal({
277+
expect(c).to.deep.equal({
278278
edges: [
279279
{
280280
node: 'B',
@@ -300,7 +300,7 @@ describe('connectionFromArray()', () => {
300300
after: 'YXJyYXljb25uZWN0aW9uOjA=',
301301
before: 'YXJyYXljb25uZWN0aW9uOjQ=',
302302
});
303-
return expect(c).to.deep.equal({
303+
expect(c).to.deep.equal({
304304
edges: [
305305
{
306306
node: 'B',
@@ -330,7 +330,7 @@ describe('connectionFromArray()', () => {
330330
after: 'YXJyYXljb25uZWN0aW9uOjA=',
331331
before: 'YXJyYXljb25uZWN0aW9uOjQ=',
332332
});
333-
return expect(c).to.deep.equal({
333+
expect(c).to.deep.equal({
334334
edges: [
335335
{
336336
node: 'B',
@@ -360,7 +360,7 @@ describe('connectionFromArray()', () => {
360360
after: 'YXJyYXljb25uZWN0aW9uOjA=',
361361
before: 'YXJyYXljb25uZWN0aW9uOjQ=',
362362
});
363-
return expect(c).to.deep.equal({
363+
expect(c).to.deep.equal({
364364
edges: [
365365
{
366366
node: 'C',
@@ -386,7 +386,7 @@ describe('connectionFromArray()', () => {
386386
after: 'YXJyYXljb25uZWN0aW9uOjA=',
387387
before: 'YXJyYXljb25uZWN0aW9uOjQ=',
388388
});
389-
return expect(c).to.deep.equal({
389+
expect(c).to.deep.equal({
390390
edges: [
391391
{
392392
node: 'B',
@@ -416,7 +416,7 @@ describe('connectionFromArray()', () => {
416416
after: 'YXJyYXljb25uZWN0aW9uOjA=',
417417
before: 'YXJyYXljb25uZWN0aW9uOjQ=',
418418
});
419-
return expect(c).to.deep.equal({
419+
expect(c).to.deep.equal({
420420
edges: [
421421
{
422422
node: 'B',
@@ -459,7 +459,7 @@ describe('connectionFromArray()', () => {
459459
before: 'invalid',
460460
after: 'invalid',
461461
});
462-
return expect(c).to.deep.equal({
462+
expect(c).to.deep.equal({
463463
edges: [
464464
{
465465
node: 'A',
@@ -496,7 +496,7 @@ describe('connectionFromArray()', () => {
496496
before: 'YXJyYXljb25uZWN0aW9uOjYK',
497497
after: 'YXJyYXljb25uZWN0aW9uOi0xCg==',
498498
});
499-
return expect(c).to.deep.equal({
499+
expect(c).to.deep.equal({
500500
edges: [
501501
{
502502
node: 'A',
@@ -533,7 +533,7 @@ describe('connectionFromArray()', () => {
533533
before: 'YXJyYXljb25uZWN0aW9uOjI=',
534534
after: 'YXJyYXljb25uZWN0aW9uOjQ=',
535535
});
536-
return expect(c).to.deep.equal({
536+
expect(c).to.deep.equal({
537537
edges: [],
538538
pageInfo: {
539539
startCursor: null,
@@ -548,12 +548,12 @@ describe('connectionFromArray()', () => {
548548
describe('cursorForObjectInConnection()', () => {
549549
it("returns an edge's cursor, given an array and a member object", () => {
550550
const letterBCursor = cursorForObjectInConnection(letters, 'B');
551-
return expect(letterBCursor).to.equal('YXJyYXljb25uZWN0aW9uOjE=');
551+
expect(letterBCursor).to.equal('YXJyYXljb25uZWN0aW9uOjE=');
552552
});
553553

554554
it('returns null, given an array and a non-member object', () => {
555555
const letterFCursor = cursorForObjectInConnection(letters, 'F');
556-
return expect(letterFCursor).to.be.null;
556+
expect(letterFCursor).to.equal(null);
557557
});
558558
});
559559
});
@@ -563,7 +563,7 @@ describe('connectionFromPromisedArray()', () => {
563563

564564
it('returns all elements without filters', async () => {
565565
const c = await connectionFromPromisedArray(letters, {});
566-
return expect(c).to.deep.equal({
566+
expect(c).to.deep.equal({
567567
edges: [
568568
{
569569
node: 'A',
@@ -597,7 +597,7 @@ describe('connectionFromPromisedArray()', () => {
597597

598598
it('respects a smaller first', async () => {
599599
const c = await connectionFromPromisedArray(letters, { first: 2 });
600-
return expect(c).to.deep.equal({
600+
expect(c).to.deep.equal({
601601
edges: [
602602
{ node: 'A', cursor: 'YXJyYXljb25uZWN0aW9uOjA=' },
603603
{
@@ -630,7 +630,7 @@ describe('connectionFromArraySlice()', () => {
630630
arrayLength: 5,
631631
},
632632
);
633-
return expect(c).to.deep.equal({
633+
expect(c).to.deep.equal({
634634
edges: [
635635
{
636636
node: 'B',
@@ -662,7 +662,7 @@ describe('connectionFromArraySlice()', () => {
662662
arrayLength: 5,
663663
},
664664
);
665-
return expect(c).to.deep.equal({
665+
expect(c).to.deep.equal({
666666
edges: [
667667
{
668668
node: 'B',
@@ -694,7 +694,7 @@ describe('connectionFromArraySlice()', () => {
694694
arrayLength: 5,
695695
},
696696
);
697-
return expect(c).to.deep.equal({
697+
expect(c).to.deep.equal({
698698
edges: [
699699
{
700700
node: 'C',
@@ -722,7 +722,7 @@ describe('connectionFromArraySlice()', () => {
722722
arrayLength: 5,
723723
},
724724
);
725-
return expect(c).to.deep.equal({
725+
expect(c).to.deep.equal({
726726
edges: [
727727
{
728728
node: 'C',
@@ -750,7 +750,7 @@ describe('connectionFromArraySlice()', () => {
750750
arrayLength: 5,
751751
},
752752
);
753-
return expect(c).to.deep.equal({
753+
expect(c).to.deep.equal({
754754
edges: [
755755
{
756756
node: 'D',
@@ -782,7 +782,7 @@ describe('connectionFromArraySlice()', () => {
782782
arrayLength: 5,
783783
},
784784
);
785-
return expect(c).to.deep.equal({
785+
expect(c).to.deep.equal({
786786
edges: [
787787
{
788788
node: 'C',
@@ -814,7 +814,7 @@ describe('connectionFromArraySlice()', () => {
814814
arrayLength: 5,
815815
},
816816
);
817-
return expect(c).to.deep.equal({
817+
expect(c).to.deep.equal({
818818
edges: [
819819
{
820820
node: 'D',
@@ -842,7 +842,7 @@ describe('connectionFromPromisedArraySlice()', () => {
842842
arrayLength: 5,
843843
},
844844
);
845-
return expect(c).to.deep.equal({
845+
expect(c).to.deep.equal({
846846
edges: [
847847
{ node: 'A', cursor: 'YXJyYXljb25uZWN0aW9uOjA=' },
848848
{

‎src/mutation/__tests__/mutation.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ describe('mutationWithClientMutationId()', () => {
440440
}
441441
`;
442442

443-
return expect(await graphql(schema, query)).to.deep.equal({
443+
expect(await graphql(schema, query)).to.deep.equal({
444444
data: {
445445
__schema: {
446446
mutationType: {
@@ -487,7 +487,7 @@ describe('mutationWithClientMutationId()', () => {
487487
}
488488
`;
489489

490-
return expect(await graphql(schema, query)).to.deep.equal({
490+
expect(await graphql(schema, query)).to.deep.equal({
491491
data: {
492492
__schema: {
493493
mutationType: {

‎src/node/__tests__/node.js

+9-9
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ describe('Node interface and fields', () => {
215215
}
216216
`;
217217

218-
return expect(await graphql(schema, query)).to.deep.equal({
218+
expect(await graphql(schema, query)).to.deep.equal({
219219
data: {
220220
node: {
221221
id: '1',
@@ -237,7 +237,7 @@ describe('Node interface and fields', () => {
237237
}
238238
`;
239239

240-
return expect(await graphql(schema, query)).to.deep.equal({
240+
expect(await graphql(schema, query)).to.deep.equal({
241241
data: {
242242
node: {
243243
id: '4',
@@ -257,7 +257,7 @@ describe('Node interface and fields', () => {
257257
}
258258
`;
259259

260-
return expect(await graphql(schema, query)).to.deep.equal({
260+
expect(await graphql(schema, query)).to.deep.equal({
261261
data: {
262262
node: {
263263
id: '1',
@@ -277,7 +277,7 @@ describe('Node interface and fields', () => {
277277
}
278278
`;
279279

280-
return expect(await graphql(schema, query)).to.deep.equal({
280+
expect(await graphql(schema, query)).to.deep.equal({
281281
data: {
282282
node: {
283283
id: '4',
@@ -299,7 +299,7 @@ describe('Node interface and fields', () => {
299299
}
300300
`;
301301

302-
return expect(await graphql(schema, query)).to.deep.equal({
302+
expect(await graphql(schema, query)).to.deep.equal({
303303
data: {
304304
node: {
305305
id: '1',
@@ -317,7 +317,7 @@ describe('Node interface and fields', () => {
317317
}
318318
`;
319319

320-
return expect(await graphql(schema, query)).to.deep.equal({
320+
expect(await graphql(schema, query)).to.deep.equal({
321321
data: {
322322
node: null,
323323
},
@@ -333,7 +333,7 @@ describe('Node interface and fields', () => {
333333
}
334334
`;
335335

336-
return expect(await graphql(schema, query)).to.deep.equal({
336+
expect(await graphql(schema, query)).to.deep.equal({
337337
data: {
338338
nodes: [
339339
{
@@ -367,7 +367,7 @@ describe('Node interface and fields', () => {
367367
}
368368
`;
369369

370-
return expect(await graphql(schema, query)).to.deep.equal({
370+
expect(await graphql(schema, query)).to.deep.equal({
371371
data: {
372372
__type: {
373373
name: 'Node',
@@ -416,7 +416,7 @@ describe('Node interface and fields', () => {
416416
}
417417
`;
418418

419-
return expect(await graphql(schema, query)).to.deep.equal({
419+
expect(await graphql(schema, query)).to.deep.equal({
420420
data: {
421421
__schema: {
422422
queryType: {

‎src/node/__tests__/nodeasync.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ describe('Node interface and fields with async object fetcher', () => {
6565
}
6666
`;
6767

68-
return expect(await graphql(schema, query)).to.deep.equal({
68+
expect(await graphql(schema, query)).to.deep.equal({
6969
data: {
7070
node: {
7171
id: '1',
@@ -86,7 +86,7 @@ describe('Node interface and fields with async object fetcher', () => {
8686
}
8787
`;
8888

89-
return expect(await graphql(schema, query)).to.deep.equal({
89+
expect(await graphql(schema, query)).to.deep.equal({
9090
data: {
9191
node: {
9292
id: '1',

0 commit comments

Comments
 (0)