Skip to content

Drop support for Windows "classic mode" #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joachimmarder opened this issue Feb 21, 2023 · 2 comments
Closed

Drop support for Windows "classic mode" #1173

joachimmarder opened this issue Feb 21, 2023 · 2 comments
Labels
Breaking Change Open for Discussion There are several possibilites to address the issue and anyone is invited for comments.
Milestone

Comments

@joachimmarder
Copy link
Contributor

Windows 7 was the last version of the operating system that supported the classic mode, which is the look introduced with Windows 95, that does not support theming. Most methods that do painting have two code paths, one for the old classic mode and one that uses the theming engine of Windows / the style services of the VCL. With the many refactorings that have been done for Virtual TreeView V8 there is a high likelihood some code paths for the classic modes are broken. However, no active testing takes places as all operating systems are outdated which still have the classic mode.

Therefore, I think the best option for those that still need to support the Windows classic mode, is to stick with the stable V7 branch and to officially deprecate the support for the classic mode in V8.

@joachimmarder joachimmarder added this to the V8.0 milestone Feb 21, 2023
@joachimmarder joachimmarder added Breaking Change Open for Discussion There are several possibilites to address the issue and anyone is invited for comments. labels Feb 21, 2023
@gwideman
Copy link

It would be helpful to state explicitly that Classic Mode is the mode set by Property XYZ = abc. Otherwise it's not so clear whether an existing application does or does not use VTV in "Classic Mode". Thanks.

@joachimmarder
Copy link
Contributor Author

There is no such property, just several places where code is used as fallback if no theme / style support is available, like on old Windows Server versions. The problem is that this code is neither tested nor maintained for years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Open for Discussion There are several possibilites to address the issue and anyone is invited for comments.
Projects
None yet
Development

No branches or pull requests

2 participants