Skip to content

Commit 0807712

Browse files
authored
fix(errors): improve message when version validation fails (#161)
Closes #160
1 parent 6fd3bc8 commit 0807712

File tree

5 files changed

+11
-6
lines changed

5 files changed

+11
-6
lines changed

Diff for: dist/main.js

+4-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: dist/main.js.map

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: src/__tests__/read-manifest.test.ts

+1
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,7 @@ describe("readManifest", () => {
217217
const result = subject.readManifest(directory);
218218

219219
await expect(result).rejects.toThrow(errors.InvalidPackageVersionError);
220+
await expect(result).rejects.toThrow(/42/iu);
220221
});
221222

222223
it("should error if publishConfig is invalid", async () => {

Diff for: src/errors.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,9 @@ export class InvalidPackageNameError extends TypeError {
6969

7070
export class InvalidPackageVersionError extends TypeError {
7171
public constructor(value: unknown) {
72-
super(`Package version must be a string, got "${String(value)}"`);
72+
super(
73+
`Package version must be a valid semantic version, got "${String(value)}"`
74+
);
7375
this.name = "InvalidPackageVersionError";
7476
}
7577
}

Diff for: src/read-manifest.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ export async function readManifest(
121121
}
122122

123123
if (typeof version !== "string") {
124-
throw new errors.InvalidPackageVersionError(version);
124+
throw new errors.InvalidPackageVersionError(manifestJson["version"]);
125125
}
126126

127127
if (

0 commit comments

Comments
 (0)