Used getValidFileName for helper method deriveFileNameFromUrl

Kaan0029 · Kaan0029 · commit 938744352cec · 2025-04-13T12:32:47.000-04:00
diff --git a/src/main/java/org/jabref/gui/externalfiles/ImportHandler.java b/src/main/java/org/jabref/gui/externalfiles/ImportHandler.java
@@ -501,9 +501,9 @@ private List<BibEntry> handlePdfUrl(String pdfUrl) throws IOException {
 
     private String deriveFileNameFromUrl(String url) {
         String fileName = url.substring(url.lastIndexOf('/') + 1);
-        if (fileName == null || fileName.isBlank()) {
+        if (fileName.isBlank()) {
             fileName = "downloaded.pdf";
         }
-        return fileName;
+        return FileUtil.getValidFileName(fileName);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -501,9 +501,9 @@ private List<BibEntry> handlePdfUrl(String pdfUrl) throws IOException {`
`501`	`501`
`502`	`502`	`private String deriveFileNameFromUrl(String url) {`
`503`	`503`	`String fileName = url.substring(url.lastIndexOf('/') + 1);`
`504`		`- if (fileName == null \|\| fileName.isBlank()) {`
	`504`	`+ if (fileName.isBlank()) {`
`505`	`505`	`fileName = "downloaded.pdf";`
`506`	`506`	`}`
`507`		`- return fileName;`
	`507`	`+ return FileUtil.getValidFileName(fileName);`
`508`	`508`	`}`
`509`	`509`	`}`