Skip to content

Commit 9ada73d

Browse files
kopporsubhramit
andauthored
Add automatic message on submodule modifications (#12752)
* Add automatic message on submodule modifications * Remove extra newline --------- Co-authored-by: Subhramit Basu <[email protected]>
1 parent 9c341e9 commit 9ada73d

File tree

2 files changed

+24
-0
lines changed

2 files changed

+24
-0
lines changed

.github/ghprcomment.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,3 +91,8 @@
9191
9292
Please [merge `upstream/main`](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork#syncing-a-fork-branch-from-the-command-line) with your code.
9393
For a step-by-step guide to resolve merge conflicts, see <https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line>.
94+
- jobName: 'Submodules not modified'
95+
message: >
96+
Your pull request modified git submodules.
97+
98+
Please follow our [FAQ on submodules](https://devdocs.jabref.org/code-howtos/faq.html#submodules) to fix.

.github/workflows/on-pr-opened.yml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,25 @@ jobs:
6363
echo "✅ No merge conflicts"
6464
env:
6565
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
66+
unmodified_submodules:
67+
name: Submodules not modified
68+
if: github.actor != 'dependabot[bot]'
69+
runs-on: ubuntu-latest
70+
steps:
71+
- uses: actions/checkout@v4
72+
with:
73+
submodules: true
74+
show-progress: 'false'
75+
- name: Check for submodule modifications
76+
id: check_submodule
77+
run: |
78+
git fetch origin ${{ github.base_ref }}
79+
DIFF=$(git diff --submodule=log origin/${{ github.base_ref }} HEAD)
80+
if [ -n "$DIFF" ]; then
81+
echo "❌ Submodule modifications detected"
82+
exit 1
83+
fi
84+
echo "✅ No submodule modifications"
6685
upload-pr-number:
6786
runs-on: ubuntu-latest
6887
steps:

0 commit comments

Comments
 (0)