refactor: move areAnyJournalSourcesEnabled() method from AbbreviateAction.java to JournalAbbreviationPreferences.java

Author: zikunz

src/main/java/org/jabref/gui/journals/AbbreviateAction.java

@@ -85,7 +85,7 @@ public AbbreviateAction(StandardActions action,
 
     @Override
     public void execute() {
-        if (action == StandardActions.UNABBREVIATE && !areAnyJournalSourcesEnabled()) {
+        if (action == StandardActions.UNABBREVIATE && !journalAbbreviationPreferences.areAnyJournalSourcesEnabled()) {
             dialogService.notify(Localization.lang("Cannot unabbreviate: all journal lists are disabled."));
             return;
         }
@@ -307,29 +307,4 @@ private JournalAbbreviationPreferences clonePreferences() {
                 journalAbbreviationPreferences.getEnabledExternalLists()
         );
     }
-    
-    /**
-     * Checks if any journal abbreviation source is enabled in the preferences.
-     * This includes both the built-in list and any external journal lists.
-     *
-     * @return true if at least one source is enabled, false if all sources are disabled
-     */
-    private boolean areAnyJournalSourcesEnabled() {
-        boolean anySourceEnabled = journalAbbreviationPreferences.isSourceEnabled(JournalAbbreviationRepository.BUILTIN_LIST_ID);
-        
-        if (!anySourceEnabled) {
-            for (String listPath : journalAbbreviationPreferences.getExternalJournalLists()) {
-                if (listPath != null && !listPath.isBlank()) {
-                    // Just check the filename since that's what's used as the source key
-                    String fileName = Path.of(listPath).getFileName().toString();
-                    if (journalAbbreviationPreferences.isSourceEnabled(fileName)) {
-                        anySourceEnabled = true;
-                        break;
-                    }
-                }
-            }
-        }
-        
-        return anySourceEnabled;
-    }
 }

src/main/java/org/jabref/logic/journals/JournalAbbreviationPreferences.java

@@ -139,4 +139,29 @@ public BooleanProperty enabledListsChangedProperty() {
     public boolean hasExplicitEnabledSetting(String sourcePath) {
         return enabledExternalLists.containsKey(sourcePath);
     }
+    
+    /**
+     * Checks if any journal abbreviation source is enabled in the preferences.
+     * This includes both the built-in list and any external journal lists.
+     *
+     * @return true if at least one source is enabled, false if all sources are disabled
+     */
+    public boolean areAnyJournalSourcesEnabled() {
+        boolean anySourceEnabled = isSourceEnabled(JournalAbbreviationRepository.BUILTIN_LIST_ID);
+        
+        if (!anySourceEnabled) {
+            for (String listPath : getExternalJournalLists()) {
+                if (listPath != null && !listPath.isBlank()) {
+                    // Just check the filename since that's what's used as the source key
+                    String fileName = java.nio.file.Path.of(listPath).getFileName().toString();
+                    if (isSourceEnabled(fileName)) {
+                        anySourceEnabled = true;
+                        break;
+                    }
+                }
+            }
+        }
+        
+        return anySourceEnabled;
+    }
 }