Skip to content

Enforce saving of library before (relative) file paths are used #12559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
koppor opened this issue Feb 24, 2025 · 18 comments
Closed

Enforce saving of library before (relative) file paths are used #12559

koppor opened this issue Feb 24, 2025 · 18 comments
Labels
component: external-files component: ui good second issue Issues that involve a tour of two or three interweaved components in JabRef

Comments

@koppor
Copy link
Member

koppor commented Feb 24, 2025

  1. Start JabRef using ./gradlew run (let that directory be X)
  2. Create new library
  3. Do not save
  4. Open Library properties: "Library-specific file directory". See that this can be changed.

Proposed workaround:

  1. Preferences
    1. Make all three library directory settings field read-only
      Image
    2. Add text "Save library first" below these fields
  2. When a user drops a PDF file onto JabRef, it should not be allowed to the user (Windows should show crossed icon)

Related: #12556, #12558, and #11920

@koppor koppor added component: external-files component: ui good first issue An issue intended for project-newcomers. Varies in difficulty. labels Feb 24, 2025
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Feb 24, 2025
@koppor koppor changed the title Enforce Enforce saving of library before (relative) file paths are used Feb 24, 2025
@madanhk18
Copy link
Contributor

Hey I would like to work on this issue . Please assign it to me

Copy link
Contributor

👋 Hey @madanhk18, it looks like you're interested in working on this issue! 🎉

If you'd like to take on this issue, please use the command /assign-me to assign yourself.

@simhadri-s
Copy link

/assign-me

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 1, 2025
Copy link
Contributor

github-actions bot commented Mar 1, 2025

👋 Hey @simhadri-s, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 45 days (by 15 April 2025). A maintainer can also add the "📌 Pinned"" label to prevent automatic unassignment.

@subhramit
Copy link
Member

@simhadri-s I am un-assigning you since someone else was interested on this before you.
@madanhk18 please use the assign command to be assigned to issues next time onwards.

@koppor koppor moved this from Free to take to Assigned in Good First Issues Mar 1, 2025
@subhramit
Copy link
Member

/unassign @simhadri-s

@github-actions github-actions bot removed the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 1, 2025
Copy link
Contributor

github-actions bot commented Mar 1, 2025

👋 Hey @simhadri-s, you've been automatically unassigned from this issue due to inactivity.

Note

If you'd like to be re-assigned, just leave another comment or ask a maintainer to assign you again.
If you're still actively working on the issue, let us know by commenting, and we can pin it to prevent automatic unassignment.

@subhramit
Copy link
Member

/assign @madanhk18

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 1, 2025
Copy link
Contributor

github-actions bot commented Mar 1, 2025

👋 Hey @madanhk18, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 45 days (by 15 April 2025). A maintainer can also add the "📌 Pinned"" label to prevent automatic unassignment.

@koppor koppor moved this from Assigned to Free to take in Good First Issues Mar 1, 2025
@subhramit subhramit moved this from Free to take to Assigned in Good First Issues Mar 1, 2025
@koppor koppor added good second issue Issues that involve a tour of two or three interweaved components in JabRef and removed good first issue An issue intended for project-newcomers. Varies in difficulty. labels Mar 12, 2025
@github-actions github-actions bot removed the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 27, 2025
Copy link
Contributor

📋 Assignment Update

Hi @madanhk18, due to inactivity, you have been unassigned from this issue.

Next steps


If you still want to work on this:

  • Submit a pull request showing your current state. You will be automatically assigned again.
  • Ask a maintainer to assign you again.

@koppor koppor moved this from Assigned to Free to take in Good First Issues Mar 27, 2025
@sanjyot242
Copy link
Contributor

Hi is this free to take ?

@subhramit
Copy link
Member

Hi is this free to take ?

Yes. You can check on the right side panel:

Image

@sanjyot242
Copy link
Contributor

/assign-me

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Apr 1, 2025
Copy link
Contributor

github-actions bot commented Apr 1, 2025

👋 Hey @sanjyot242, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

Copy link
Contributor

⏰ Assignment Reminder

Hi @sanjyot242, this is a friendly reminder about your assignment to this issue.

Warning

This issue will be automatically unassigned in 11 days if there's no activity.

How to keep your assignment


If you are working on it, you can prevent automatic unassignment by:

  • Submitting a draft PR with your progress
  • Asking for the 📌 Pinned label if you need more time

We appreciate your contribution and are here to help if needed!

@github-actions github-actions bot removed 📍 Assigned Assigned by assign-issue-action (or manually assigned) 🔔 reminder-sent labels May 8, 2025
Copy link
Contributor

github-actions bot commented May 8, 2025

📋 Assignment Update

Hi @sanjyot242, due to inactivity, you have been unassigned from this issue.

Next steps


If you still want to work on this:

  • Submit a pull request showing your current state. You will be automatically assigned again.
  • Ask a maintainer to assign you again.

@paudelritij
Copy link
Contributor

I think this issue needs to be updated @koppor we discussed a bit of this in #13029 (comment) ...

@koppor
Copy link
Member Author

koppor commented May 8, 2025

@paudelritij Yeah, I think, we came up with a better solution. Thank you for the thing.

@koppor koppor closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: external-files component: ui good second issue Issues that involve a tour of two or three interweaved components in JabRef
Projects
None yet
Development

No branches or pull requests

6 participants