Skip to content

When fetching from DOI: Dialog should select field data based on validity #12549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
koppor opened this issue Feb 23, 2025 · 9 comments · May be fixed by #12826
Open

When fetching from DOI: Dialog should select field data based on validity #12549

koppor opened this issue Feb 23, 2025 · 9 comments · May be fixed by #12826
Assignees
@AndraRice @Menoa11
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) component: fetcher component: ui good first issue An issue intended for project-newcomers. Varies in difficulty. 📌 Pinned

Comments

@koppor
Copy link
Member

koppor commented Feb 23, 2025

As user, I can refine entry's data using a DOI. See https://docs.jabref.org/finding-sorting-and-cleaning-entries/getbibtexdatafromdoi#completing-information-based-on-doi-or-isbn for an example.

Then, for any field, it could be possible that information is existing locally ("Original entry") and from the DOI ("Entry from DOI").

Example:

Image

However, sometimes, the local data is really wrong. In this example, the "year" (1109) and the "Entrytype" (Misc).

The dialog should select the data which could be more right. Here, "Entrytype" and "Year" should be selected from "Entry from DOI":

Image

Task

  1. Find out how the Merge Entries Dialog is called
  2. Modify it to know that it knows that is called from "get bibliographic data from DOI" (or not)
  3. If called from "get bibliographic data from DOI", then it should go through all fields existing in both entries and select the ones more "right". Implement it for entry type (misc; != misc) and year. - Also use "DOI" from the "DOI" fetcher (if code-wise clean enough)

Details

The dialog currently prioritizes the entry from the library. Sometimes, the data from the library is really wrong.

Example:

@Misc{,
  year      = {1109},
  doi       = {10.1109/IPDPSW55747.2022.00093},
  publisher = {IEEE},
}
  1. Wrong entry type
  2. Wrong year

When the merge entries dialog is started, it should select the more propriate entry type (everything else as MISC is better) and the better year (if year differs more than 10 years, the "new" year should be taken)
@koppor koppor added good first issue An issue intended for project-newcomers. Varies in difficulty. component: fetcher component: ui labels Feb 23, 2025
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Feb 23, 2025
@AndraRice
Copy link

/assign-me

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 3, 2025

👋 Hey @AndraRice, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 45 days (by 17 April 2025). A maintainer can also add the "📌 Pinned"" label to prevent automatic unassignment.

@subhramit subhramit moved this from Free to take to Assigned in Good First Issues Mar 11, 2025
@Paras-Gupta16
Copy link
Contributor

/assign-me

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Issue Already Assigned

Hi @Paras-Gupta16, this issue is currently assigned to @AndraRice.

Note

If no progress is made within ** days**, the issue will be automatically unassigned.

Options for contributors
  • Wait for availability: The issue may become available if auto-unassigned
  • Collaborate: You can ask @AndraRice if they want help
  • Maintainer assistance: A maintainer can add you as co-assignee if appropriate

@Paras-Gupta16
Copy link
Contributor

Hey @AndraRice, are you currently working on this? If not, I'd be happy to take it on.

@Menoa11
Copy link

Menoa11 commented Mar 21, 2025

@Paras-Gupta16 Our team is currently working on it

@koppor
Copy link
Member Author

koppor commented Mar 21, 2025

@Menoa11 May we ask about an initial Pull Request? May we also ask about a deadline from your side?

@Menoa11
Copy link

Menoa11 commented Mar 21, 2025

@koppor our assignment is due on March 31st so there will for sure be a pull request with the change by then.

@koppor
Copy link
Member Author

koppor commented Mar 21, 2025

@koppor our assignment is due on March 31st so there will for sure be a pull request with the change by then.

Please keep in mind that we aim for contributions included. Thus, submit early to provide us time for feedback. Preferrably at least half the time you required to send the initial PR. Then, there will be feedback. Then we pray that you address the feedback. Please keep in mind that some bots will check the minimum requirements. We wish that addressing this will take one day only. Finally, we really hope that contributors appreciate working on a project used by thousands of people worldwide and take their improvements more serious than just a throw-away excersice to get some study credit points. Contributor appreciation motivates us to spend our free time to a) provide individual feedback and b) keep the whole flow running.

@Menoa11 Menoa11 linked a pull request Mar 25, 2025 that will close this issue
Draft
7 tasks
@koppor koppor moved this from Assigned to In Progress in Good First Issues Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndraRice AndraRice

@Menoa11 Menoa11

Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) component: fetcher component: ui good first issue An issue intended for project-newcomers. Varies in difficulty. 📌 Pinned
Projects
Good First Issues
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix when fetching from DOI: Dialog selects field data based on validity Menoa11/jabref_groupproject
4 participants
@koppor @AndraRice @Menoa11 @Paras-Gupta16