Skip to content

Commit 4e64659

Browse files
committed
Revert go-to-implementation changes
1 parent bea3de0 commit 4e64659

5 files changed

+6
-7
lines changed

src/services/findAllReferences.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -2313,10 +2313,10 @@ namespace ts.FindAllReferences {
23132313
}
23142314

23152315
function isImplementation(node: Node): boolean {
2316-
return !(node.flags & NodeFlags.Ambient) && (
2316+
return !!(node.flags & NodeFlags.Ambient) ? !(isInterfaceDeclaration(node) || isTypeAliasDeclaration(node)) :
23172317
(isVariableLike(node) ? hasInitializer(node) :
23182318
isFunctionLikeDeclaration(node) ? !!node.body :
2319-
isClassLike(node) || isModuleOrEnumDeclaration(node)));
2319+
isClassLike(node) || isModuleOrEnumDeclaration(node));
23202320
}
23212321

23222322
export function getReferenceEntriesForShorthandPropertyAssignment(node: Node, checker: TypeChecker, addReference: (node: Node) => void): void {

tests/cases/fourslash/goToDefinitionExpandoElementAccess.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44
////f[/*0*/"x"] = 0;
55
////f[[|/*1*/"x"|]] = 1;
66

7-
verify.goToDefinition("1", ["0", "1"]);
7+
verify.goToDefinition("1", "0");

tests/cases/fourslash/goToImplementationLocal_06.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@
55
//// declare var [|someVar|]: string;
66
//// someVa/*reference*/r
77

8-
verify.implementationListIsEmpty();
8+
verify.allRangesAppearInImplementationList("reference");

tests/cases/fourslash/goToImplementationLocal_07.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@
55
//// declare function [|someFunction|](): () => void;
66
//// someFun/*reference*/ction();
77

8-
verify.implementationListIsEmpty();
8+
verify.allRangesAppearInImplementationList("reference");

tests/cases/fourslash/goToImplementationLocal_08.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,4 @@
55
//// declare function [|someFunction|](): () => void;
66
//// someFun/*reference*/ction();
77

8-
goTo.marker("reference");
9-
verify.implementationListIsEmpty();
8+
verify.allRangesAppearInImplementationList("reference");

0 commit comments

Comments
 (0)