Merge pull request #9 from Jalalx/bugfix/string-param-route

fixed a bug related to string parameter in route

Author: Jalalx

samples/SampleRestApi/Controllers/UserController.cs

@@ -60,6 +60,25 @@ public IActionResult SearchByName(string name)
             return Ok(result);
         }
 
+        [HttpGet("by-name/{name}")]
+        public IActionResult GetByName(string name)
+        {
+            if (string.IsNullOrWhiteSpace(name))
+            {
+                return BadRequest();
+            }
+
+            var result = _users.FirstOrDefault(x =>
+                        x.FirstName.Contains(name, StringComparison.OrdinalIgnoreCase) ||
+                        x.LastName.Contains(name, StringComparison.OrdinalIgnoreCase));
+            if (result == null)
+            {
+                return NotFound();
+            }
+
+            return Ok(result);
+        }
+
         [HttpGet("wrapped/search")]
         public IActionResult WrappedSearchByName(string name)
         {

src/HttpClientGenerator/HttpClientGenerator.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <TargetFramework>netstandard2.0</TargetFramework>
-    <Version>0.6.0</Version>
+    <Version>0.6.1</Version>
     <LangVersion>9.0</LangVersion>
   </PropertyGroup>
   <PropertyGroup>

src/HttpClientGenerator/Internals/PartialServiceClassSourceBuilder.cs

@@ -309,7 +309,7 @@ private void DefinePathAndRouteAndQueryParameter(SourceBuilder source, Attribute
 
         private bool IsValidParameter(ITypeSymbol type)
         {
-            if (!type.IsValueType)
+            if (type.FullName() != typeof(string).FullName && !type.IsValueType)
             {
                 return false;
             }

tests/HttpClientCodeGeneratorIntegrationTests/Basics/MyHttpClientBasicScenarioTests.cs

@@ -38,6 +38,23 @@ public async Task GetUser_ByValidId_ReturnsExpectedValue()
             Assert.Equal("+981234567", user.PhoneNumber);
         }
 
+        // Fetch by name
+        [Fact]
+        public async Task GetUser_ByValidName_ReturnsExpectedValue()
+        {
+            // Arrange
+            var client = _factory.CreateClient();
+            var myClient = new MyHttpService(client);
+
+            // Act
+            var user = await myClient.GetUserByNameAsync("Will");
+
+            // Assert
+            Assert.Equal("Will", user.FirstName);
+            Assert.Equal("Smith", user.LastName);
+            Assert.Equal("+981234567", user.PhoneNumber);
+        }
+
         [Fact]
         public async Task GetUser_ByInvalidId_Throws404HttpRequestException()
         {

tests/HttpClientCodeGeneratorIntegrationTests/Basics/MyHttpService.cs

@@ -25,6 +25,9 @@ public MyHttpService(HttpClient httpClient)
         [HttpGet("user/search")]
         public partial Task<IEnumerable<User>> SearchUserByNameAsync(string name);
 
+        [HttpGet("user/by-name/{name}")]
+        public partial Task<User> GetUserByNameAsync(string name);
+
         [HttpPost("user")]
         public partial Task<User> CreateUser(User user);