Skip to content

Commit 5e1e531

Browse files
committed
Nuget pack fixes:
- Swapped deprecated PackageIconUrl for PackageIcon. - Made generator projects unpackable.
1 parent 2fbb345 commit 5e1e531

File tree

5 files changed

+8
-1
lines changed

5 files changed

+8
-1
lines changed

Jering.Javascript.NodeJS.sln

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
1616
keypair.snk = keypair.snk
1717
License.md = License.md
1818
NuGet.Config = NuGet.Config
19+
src\NodeJS\nuget_icon.png = src\NodeJS\nuget_icon.png
1920
ReadMe.md = ReadMe.md
2021
ThirdPartyLicenses.txt = ThirdPartyLicenses.txt
2122
EndProjectSection

generators/Jering.Javascript.NodeJS.CodeGenerators/Jering.Javascript.NodeJS.CodeGenerators.csproj

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
<RunAnalyzersDuringLiveAnalysis>False</RunAnalyzersDuringLiveAnalysis>
1414
<EnableNETAnalyzers>True</EnableNETAnalyzers>
1515
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
16+
<IsPackable>false</IsPackable>
1617
</PropertyGroup>
1718

1819
<ItemGroup>

generators/Jering.Javascript.NodeJS.DocumentationGenerators/Jering.Javascript.NodeJS.DocumentationGenerators.csproj

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
<PropertyGroup>
44
<TargetFramework>netstandard2.0</TargetFramework>
55
<LangVersion>preview</LangVersion>
6+
<IsPackable>false</IsPackable>
67
</PropertyGroup>
78

89
<ItemGroup>

src/NodeJS/Jering.Javascript.NodeJS.csproj

+5-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
1919
<RepositoryType>git</RepositoryType>
2020
<GenerateDocumentationFile>true</GenerateDocumentationFile>
21-
<PackageIconUrl>https://raw.githubusercontent.com/JeringTech/Javascript.NodeJS/master/nuget_icon.png</PackageIconUrl>
21+
<PackageIcon>nuget_icon.png</PackageIcon>
2222
<Http11ServerFileName>Http11Server.js</Http11ServerFileName>
2323
<Http20ServerFileName>Http20Server.js</Http20ServerFileName>
2424
<!-- Exclude Javascript\bin and Javascript\node_modules from project - https://github.com/dotnet/cli/issues/7525 -->
@@ -70,6 +70,10 @@
7070
<ProjectReference Condition=" '$(TargetFramework)' == 'net7.0' " Include="..\..\generators\Jering.Javascript.NodeJS.DocumentationGenerators\Jering.Javascript.NodeJS.DocumentationGenerators.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />
7171
</ItemGroup>
7272

73+
<ItemGroup>
74+
<None Include="..\..\nuget_icon.png" Pack="true" PackagePath="\"/>
75+
</ItemGroup>
76+
7377
<ItemGroup>
7478
<Compile Update="Strings.Designer.cs">
7579
<DesignTime>True</DesignTime>

src/NodeJS/nuget_icon.png

3.37 KB
Loading

0 commit comments

Comments
 (0)