Skip to content

Commit 5543c4b

Browse files
tremesJoaoFula
authored andcommitted
changelog script - parse arguments as time (openshift#882)
1 parent 2887a3f commit 5543c4b

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

cmd/changelog/main.go

+10-3
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import (
1313
"sort"
1414
"strconv"
1515
"strings"
16+
"time"
1617
)
1718

1819
// norevive
@@ -100,8 +101,14 @@ func main() {
100101
var releaseBlocks map[ReleaseVersion]MarkdownReleaseBlock
101102
if len(os.Args) == 3 {
102103
releaseBlocks = make(map[ReleaseVersion]MarkdownReleaseBlock)
103-
after := os.Args[1]
104-
until := os.Args[2]
104+
after, err := time.Parse(time.DateOnly, os.Args[1])
105+
if err != nil {
106+
log.Fatalf("Failed to parse time arguments: %v", err)
107+
}
108+
until, err := time.Parse(time.DateOnly, os.Args[2])
109+
if err != nil {
110+
log.Fatalf("Failed to parse time arguments: %v", err)
111+
}
105112
gitLog = timeFrameReverseGitLog(after, until)
106113
} else {
107114
releaseBlocks = readCHANGELOG()
@@ -336,7 +343,7 @@ func findEarliestRelease(releases ReleaseVersions) ReleaseVersion {
336343
return releases[0]
337344
}
338345

339-
func timeFrameReverseGitLog(after, until string) []string {
346+
func timeFrameReverseGitLog(after, until time.Time) []string {
340347
// nolint: gosec
341348
out, err := exec.Command(
342349
"git",

0 commit comments

Comments
 (0)