Skip to content

Commit 7014aed

Browse files
William Monkwmonk
William Monk
authored andcommitted
Fix Code Review
1 parent 4d9c829 commit 7014aed

File tree

6 files changed

+40
-14
lines changed

6 files changed

+40
-14
lines changed

.github/ISSUE_TEMPLATE.md

+4
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,11 @@
8383
2. `node -v`:
8484
3. `npm -v`:
8585
4. `yarn --version` (if you use Yarn):
86+
<<<<<<< HEAD
8687
5. `npm ls react-scripts` (if you haven’t ejected):
88+
=======
89+
3. `npm ls react-scripts-ts` (if you haven’t ejected):
90+
>>>>>>> Fix Code Review
8791
8892
Then, specify:
8993

packages/react-scripts/config/webpack.config.dev.js

+11-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,17 @@ module.exports = {
9595
// https://github.com/facebookincubator/create-react-app/issues/290
9696
// `web` extension prefixes have been added for better support
9797
// for React Native Web.
98-
extensions: ['.web.ts', '.ts', '.tsx', '.web.tsx', '.web.js', '.js', '.json', '.web.jsx', '.jsx'],
98+
extensions: [
99+
'.web.ts',
100+
'.ts',
101+
'.web.tsx',
102+
'.tsx',
103+
'.web.js',
104+
'.js',
105+
'.json',
106+
'.web.jsx',
107+
'.jsx',
108+
],
99109
alias: {
100110
// @remove-on-eject-begin
101111
// Resolve Babel runtime relative to react-scripts.

packages/react-scripts/config/webpack.config.prod.js

+11-1
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,17 @@ module.exports = {
9595
// https://github.com/facebookincubator/create-react-app/issues/290
9696
// `web` extension prefixes have been added for better support
9797
// for React Native Web.
98-
extensions: ['.web.ts', '.ts', '.tsx', '.web.tsx', '.web.js', '.js', '.json', '.web.jsx', '.jsx'],
98+
extensions: [
99+
'.web.ts',
100+
'.ts',
101+
'.web.tsx',
102+
'.tsx',
103+
'.web.js',
104+
'.js',
105+
'.json',
106+
'.web.jsx',
107+
'.jsx',
108+
],
99109
alias: {
100110
// @remove-on-eject-begin
101111
// Resolve Babel runtime relative to react-scripts.

packages/react-scripts/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@
2222
"react-scripts-ts": "./bin/react-scripts-ts.js"
2323
},
2424
"dependencies": {
25-
"autoprefixer": "7.1.0",
2625
"autoprefixer": "7.1.1",
2726
"app-root-path": "^2.0.1",
2827
"case-sensitive-paths-webpack-plugin": "2.1.1",
2928
"chalk": "1.1.3",
29+
"chalk": "1.1.3",
3030
"cli-highlight": "1.1.4",
31-
"css-loader": "0.28.1",
31+
"css-loader": "0.28.4",
3232
"dotenv": "4.0.0",
3333
"extract-text-webpack-plugin": "2.1.2",
3434
"file-loader": "0.11.2",
@@ -52,7 +52,7 @@
5252
"sw-precache-webpack-plugin": "0.11.3",
5353
"url-loader": "0.5.8",
5454
"webpack": "2.6.1",
55-
"webpack-dev-server": "2.4.5",
55+
"webpack-dev-server": "2.5.0",
5656
"webpack-manifest-plugin": "1.1.0",
5757
"whatwg-fetch": "2.0.3"
5858
},

packages/react-scripts/scripts/utils/createJestConfig.js

+11-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,17 @@ module.exports = (resolve, rootDir) => {
2727
collectCoverageFrom: ['src/**/*.{js,jsx,ts,tsx}'],
2828
setupFiles: [resolve('config/polyfills.js')],
2929
setupTestFrameworkScriptFile: setupTestsFile,
30-
moduleFileExtensions: ['web.ts', 'ts', 'web.tsx', 'tsx', 'js', 'jsx', 'json'],
30+
moduleFileExtensions: [
31+
'web.ts',
32+
'ts',
33+
'web.tsx',
34+
'tsx',
35+
'web.js',
36+
'js',
37+
'web.jsx',
38+
'jsx',
39+
'json',
40+
],
3141
testMatch: [
3242
'<rootDir>/src/**/__tests__/**/*.ts?(x)',
3343
'<rootDir>/src/**/?(*.)(spec|test).ts?(x)',

packages/react-scripts/template/src/index.js

-8
This file was deleted.

0 commit comments

Comments
 (0)