Skip to content

pylint errors stay around after deleting code file in working copy #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bersbersbers opened this issue May 29, 2018 · 7 comments
Closed
Assignees

Comments

@bersbersbers
Copy link

  • VSCode Version: 1.23.1
  • OS Version: Win 10 1803
  • Extension Version: 1.29.0
  • System Language: English
  • SVN Version: TortoiseSVN 1.10.0
    svn, version 1.10.0-dev (under development)
    compiled Apr 14 2018, 10:24:15 on x86-microsoft-windows

Issue

After deleting some bug.py, pylint errors for bug.py stay around. I could repro this with python and with latex files. I have reported
microsoft/vscode#49187
yet I am told this has to do with extensions. I have reported
microsoft/vscode-python#1235
but am told they cannot reproduce.

Steps to Reproduce

In Windows Explorer:

  1. Create folder "Repo" somewhere
  2. Using TortoiseSVN, "create repository here"
  3. Create folder "Work" somewhere
  4. Checkout from "Repo"

In VS Code:

  1. Install Python extension
  2. Using Ctrl-K-O, open "Work"
  3. Ctrl-N, type "öäü", Ctrl-S, save as "bug.py"
  4. Click the "(x) 1 /!\ 0" in the status bar (bottom left) to open "Problems". Note the problem (undefined variable öäü).
  5. Right-click "bug.py" in "Work", Delete
  6. Note the problem sticks around.

SVN Output

Using svn "svn, version 1.10.0-dev (under development)" from "C:\Program Files\TortoiseSVN\bin\svn.exe"
[xyz]$ svn info --xml
[xyz]$ svn stat --xml --no-ignore --ignore-externals
[xyz]$ svn info --xml
[xyz]$ svn log -r BASE:HEAD -q --xml
[xyz]$ svn stat --xml --no-ignore --ignore-externals
[xyz]$ svn cat bug.py
svn: warning: W200005: 'C:\Src\xyz\bug.py' is not under version control
svn: E200009: Could not cat all targets because some targets are not versioned
svn: E200009: Illegal target for the requested operation

[xyz]$ svn stat --xml --no-ignore --ignore-externals
[xyz]$ svn stat --xml --no-ignore --ignore-externals
@JohnstonCode
Copy link
Owner

Not sure how my extension could be affecting the python extension. I will have to take a look tonight when I have a windows machine available.

@JohnstonCode JohnstonCode self-assigned this Jun 9, 2018
@JohnstonCode
Copy link
Owner

I am able to replicate this.

@JohnstonCode
Copy link
Owner

JohnstonCode commented Jun 9, 2018

Seems like this line is the cause. This is used by the QuickDiffProvider. I'm assuming that it saves the uri and the linter is using that

@JohnstonCode
Copy link
Owner

I have previously created this PR for another python extension related issue.

@bersbersbers
Copy link
Author

Thanks for investigating! Should I expect that PR to solve the issue? If so, note that I can reproduce the same issue with a Latex extension, so I wonder how this could be solved in a general way (in VSCode, maybe?)

@JohnstonCode
Copy link
Owner

No that PR was to fix a duplication bug. I should be able to fix it by changing the uri scheme just need to see where I use it in the codebase

@bersbersbers
Copy link
Author

Looks good to me, thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants