Skip to content

Official python extension with pylint runs on duplicate SVN files #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Zeddicus414 opened this issue Dec 14, 2017 · 4 comments
Closed
Assignees

Comments

@Zeddicus414
Copy link

To start, I love the work you guys are doing! Excellent SVN package so far, thank you!

The problem: Pylint is wanting to lint svn files... So the warnings, etc are printed twice for every file.
image

I'm asking you guys for help since you might know what's up. It seems that the python extension settings should be capable of ignoring SVN files, but I have not been able to fix it on the Python extension side so far. I've tried a bunch of different ignore patterns there as well, such as this:
"python.linting.ignorePatterns": [ ".vscode/*.py", "**/site-packages/**/*.py", "svn*/**" ]

Another note is that if I click on the pylint warning messages for the SVN copy of the file, I can actually get two editors open of the same file and they are nearly identical.

If you guys can help, it would be greatly appreciated.

  • VSCode Version: Code 1.18.1 (929bacba01ef658b873545e26034d1a8067445e9, 2017-11-16T18:32:36.023Z)
  • OS Version: Windows_NT x64 6.1.7601
  • Extensions:
Extension Author (truncated) Version
Bookmarks ale 0.18.0
vscode-eslint dba 1.4.3
xml Dot 1.9.2
tslint eg2 1.0.24
svn-scm joh 1.4.5
mssql ms- 1.3.0
python ms- 0.8.0
vscode-code-outline pat 0.0.12
vscode-icons rob 7.19.0
@JohnstonCode
Copy link
Owner

Thanks for raising this. I will look into it and sort something out.

@JohnstonCode JohnstonCode self-assigned this Dec 16, 2017
@JohnstonCode
Copy link
Owner

JohnstonCode commented Dec 16, 2017

Seem the issue is with this line in the python extension

https://github.com/DonJayamanne/pythonVSCode/blob/c8db3459563964dfc6a06188e46a14f010221d69/src/client/providers/lintProvider.ts#L25

The Uri schemas to ignore are hard coded.

I will create a PR to have svn added

@JohnstonCode
Copy link
Owner

The changes have been merged in the python extension. Not sure when it will be rolled out tho.

@Zeddicus414
Copy link
Author

@JohnstonCode , thanks so much for the timely and helpful work. I'm looking forward to using your extension without the pylint troubles!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants