Skip to content

Commit 3d30a68

Browse files
authored
feat: are the types wrong workflow (#1644)
<!-- 👋 Hi, thanks for sending a PR to create-typescript-app! 💖. Please fill out all fields below and make sure each item is true and [x] checked. Otherwise we may not be able to review your PR. --> ## PR Checklist - [x] Addresses an existing open issue: fixes #1633 - [ ] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md) were taken ## Overview <!-- Description of what is changed and how the code change does that. --> This is a prospective PR following discussion in #1633 to add an `are the types wrong` workflow that checks CTA itself. Given CTA is ESM only, we do not check for CJS. See also #1633 (comment)
1 parent 3ffb5f9 commit 3d30a68

File tree

2 files changed

+21
-0
lines changed

2 files changed

+21
-0
lines changed

.github/workflows/ci.yml

+8
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,12 @@
11
jobs:
2+
are_the_types_wrong:
3+
name: Are the types wrong?
4+
runs-on: ubuntu-latest
5+
steps:
6+
- uses: actions/checkout@v4
7+
- uses: ./.github/actions/prepare
8+
- run: pnpm build
9+
- run: npx --yes @arethetypeswrong/cli --pack . --ignore-rules cjs-resolves-to-esm
210
build:
311
name: Build
412
runs-on: ubuntu-latest

script/__snapshots__/migrate-test-e2e.ts.snap

+13
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,19 @@
33
exports[`expected file changes > .github/workflows/ci.yml 1`] = `
44
"--- a/.github/workflows/ci.yml
55
+++ b/.github/workflows/ci.yml
6+
@@ ... @@
7+
jobs:
8+
- are_the_types_wrong:
9+
- name: Are the types wrong?
10+
- runs-on: ubuntu-latest
11+
- steps:
12+
- - uses: actions/checkout@v4
13+
- - uses: ./.github/actions/prepare
14+
- - run: pnpm build
15+
- - run: npx --yes @arethetypeswrong/cli --pack . --ignore-rules cjs-resolves-to-esm
16+
build:
17+
name: Build
18+
runs-on: ubuntu-latest
619
@@ ... @@ jobs:
720
- uses: ./.github/actions/prepare
821
- run: pnpm run test --coverage

0 commit comments

Comments
 (0)