Switch to execaCommand

Author: JoshuaKGoldberg

Diff for: src/shared/packages.test.ts

@@ -2,32 +2,39 @@ import { describe, expect, it, vi } from "vitest";
 
 import { removeDependencies } from "./packages.js";
 
-const mock$ = vi.fn();
+const mockExecaCommand = vi.fn();
 
 vi.mock("execa", () => ({
-	get $() {
-		return mock$;
+	get execaCommand() {
+		return mockExecaCommand;
 	},
 }));
 
 describe("removeDependencies", () => {
+	it("removes all packages that already exist when all already exist", async () => {
+		await removeDependencies(["one", "two"], {
+			one: "1.2.3",
+			two: "4.5.6",
+		});
+
+		expect(mockExecaCommand.mock.calls).toMatchInlineSnapshot(`
+			[
+			  [
+			    "pnpm remove one two",
+			  ],
+			]
+		`);
+	});
+
 	it("removes only packages that already exist when some don't exist", async () => {
 		await removeDependencies(["exists", "missing"], {
 			exists: "1.2.3",
 		});
 
-		expect(mock$.mock.calls).toMatchInlineSnapshot(`
+		expect(mockExecaCommand.mock.calls).toMatchInlineSnapshot(`
 			[
 			  [
-			    [
-			      "pnpm remove ",
-			      "",
-			      "",
-			    ],
-			    [
-			      "exists",
-			    ],
-			    "",
+			    "pnpm remove exists",
 			  ],
 			]
 		`);
@@ -42,18 +49,10 @@ describe("removeDependencies", () => {
 			"-D",
 		);
 
-		expect(mock$.mock.calls).toMatchInlineSnapshot(`
+		expect(mockExecaCommand.mock.calls).toMatchInlineSnapshot(`
 			[
 			  [
-			    [
-			      "pnpm remove ",
-			      "",
-			      "",
-			    ],
-			    [
-			      "exists",
-			    ],
-			    " -D",
+			    "pnpm remove exists -D",
 			  ],
 			]
 		`);
@@ -62,6 +61,6 @@ describe("removeDependencies", () => {
 	it("does nothing when no packages already exist", async () => {
 		await removeDependencies(["missing"]);
 
-		expect(mock$.mock.calls).toMatchInlineSnapshot("[]");
+		expect(mockExecaCommand.mock.calls).toMatchInlineSnapshot("[]");
 	});
 });

Diff for: src/shared/packages.ts

@@ -1,4 +1,4 @@
-import { $ } from "execa";
+import { execaCommand } from "execa";
 
 import { readFileSafe } from "./readFileSafe.js";
 import { PartialPackageData } from "./types.js";
@@ -17,6 +17,8 @@ export async function removeDependencies(
 	const present = packageNames.filter((packageName) => packageName in existing);
 
 	if (present.length) {
-		await $`pnpm remove ${present}${flags ? ` ${flags}` : ""}`;
+		await execaCommand(
+			`pnpm remove ${present.join(" ")}${flags ? ` ${flags}` : ""}`,
+		);
 	}
 }